Skip to content

Commit

Permalink
fs: improve ExistsSync performance
Browse files Browse the repository at this point in the history
  • Loading branch information
anonrig committed Jun 21, 2024
1 parent d335487 commit e2b3156
Showing 1 changed file with 1 addition and 18 deletions.
19 changes: 1 addition & 18 deletions src/node_file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1003,24 +1003,7 @@ static void ExistsSync(const FunctionCallbackInfo<Value>& args) {
THROW_IF_INSUFFICIENT_PERMISSIONS(
env, permission::PermissionScope::kFileSystemRead, path.ToStringView());

uv_fs_t req;
auto make = OnScopeLeave([&req]() { uv_fs_req_cleanup(&req); });
FS_SYNC_TRACE_BEGIN(access);
int err = uv_fs_access(nullptr, &req, path.out(), 0, nullptr);
FS_SYNC_TRACE_END(access);

#ifdef _WIN32
// In case of an invalid symlink, `uv_fs_access` on win32
// will **not** return an error and is therefore not enough.
// Double check with `uv_fs_stat()`.
if (err == 0) {
FS_SYNC_TRACE_BEGIN(stat);
err = uv_fs_stat(nullptr, &req, path.out(), nullptr);
FS_SYNC_TRACE_END(stat);
}
#endif // _WIN32

args.GetReturnValue().Set(err == 0);
args.GetReturnValue().Set(std::filesystem::exists(path.ToStringView()));
}

// Used to speed up module loading. Returns 0 if the path refers to
Expand Down

0 comments on commit e2b3156

Please sign in to comment.