Skip to content

Commit

Permalink
stream: inline and simplify onwritedrain
Browse files Browse the repository at this point in the history
Inline and simplify onwritedrain. Also remove comment that seems to be
outdated/invalid.

PR-URL: #29037
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
ronag authored and targos committed Aug 19, 2019
1 parent c396b2a commit e543d35
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions lib/_stream_writable.js
Original file line number Diff line number Diff line change
Expand Up @@ -478,21 +478,13 @@ function onwrite(stream, er) {
}

function afterWrite(stream, state, finished, cb) {
if (!finished)
onwriteDrain(stream, state);
state.pendingcb--;
cb();
finishMaybe(stream, state);
}

// Must force callback to be called on nextTick, so that we don't
// emit 'drain' before the write() consumer gets the 'false' return
// value, and has a chance to attach a 'drain' listener.
function onwriteDrain(stream, state) {
if (state.length === 0 && state.needDrain) {
if (!finished && state.length === 0 && state.needDrain) {
state.needDrain = false;
stream.emit('drain');
}
state.pendingcb--;
cb();
finishMaybe(stream, state);
}

// If there's something in the buffer waiting, then process it
Expand Down

0 comments on commit e543d35

Please sign in to comment.