Skip to content

Commit

Permalink
build: disable -Og when building with clang
Browse files Browse the repository at this point in the history
clang does not yet support -Og, fall back to -O0.

See: https://llvm.org/bugs/show_bug.cgi?id=20765
Fixes: #1608
PR-URL: #1609
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
  • Loading branch information
bnoordhuis committed May 4, 2015
1 parent 279f611 commit e67542a
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,13 @@
'v8_enable_handle_zapping%': 1,
},
'defines': [ 'DEBUG', '_DEBUG' ],
'cflags': [ '-g', '-Og' ],
'cflags': [ '-g' ],
'conditions': [
['clang==1', {
'cflags': [ '-O0' ], # https://llvm.org/bugs/show_bug.cgi?id=20765
}, {
'cflags': [ '-Og' ], # Debug-friendly optimizations only.
}],
['target_arch=="x64"', {
'msvs_configuration_platform': 'x64',
}],
Expand Down

0 comments on commit e67542a

Please sign in to comment.