Skip to content

Commit

Permalink
deps: sync V8 embedder string with master branch
Browse files Browse the repository at this point in the history
To avoid conflicts while cherry-picking future V8 backports, increment
the embedder string by one so it has the same value as in the master
branch. The value was off by one because of an ABI-breaking backport
that could not be taken in v10.x.

Refs: #22106

PR-URL: #22573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
targos committed Aug 30, 2018
1 parent 09a824f commit ea72368
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.18',
'v8_embedder_string': '-node.19',

# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,
Expand Down

0 comments on commit ea72368

Please sign in to comment.