Skip to content

Commit

Permalink
test: move some test from sequential to parallel
Browse files Browse the repository at this point in the history
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: #6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
  • Loading branch information
santigimeno authored and jasnell committed Apr 9, 2016
1 parent a9aa199 commit eaab17c
Show file tree
Hide file tree
Showing 20 changed files with 13 additions and 8 deletions.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
13 changes: 13 additions & 0 deletions test/parallel/test-stdin-child-proc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
'use strict';
// This tests that pausing and resuming stdin does not hang and timeout
// when done in a child process. See test/parallel/test-stdin-pause-resume.js
const common = require('../common');
const assert = require('assert');
const child_process = require('child_process');
const path = require('path');
const cp = child_process.spawn(process.execPath,
[path.resolve(__dirname, 'test-stdin-pause-resume.js')]);

cp.on('exit', common.mustCall((code) => {
assert.equal(code, 0);
}));
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
8 changes: 0 additions & 8 deletions test/sequential/test-stdin-child-proc.js

This file was deleted.

0 comments on commit eaab17c

Please sign in to comment.