Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: cases to querystring related to empty string
+ Add cases to `qs.stringify` that return empty string + Add cases to `qs.parse` when `sep` or `eq` is empty PR-URL: #11329 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- Loading branch information
eec216f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, no big deal, but for the future: first word of commit message after subsystem should be an imperative verb. This probably should have been something like
test: add empty-string cases to querystring
eec216f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, right, completely overlooked that... sorry about that
eec216f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of been wondering if we should make that a recommendation rather than a hard requirement anyway, to be honest.
eec216f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(And, actually, I see the doc says "should" and not "must" so I guess you could make the case it's already a recommendation but not a requirement. Thus ends my commit-comment storm. You may now go back to enjoying your day.)
eec216f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO something with a verb like
test: add empty string cases to querystring
would have been clearer, it's not the end of the world, but looking atgit log --oneline
requires parsing a lot of very dense information, and every bit of readability helps.