Skip to content

Commit

Permalink
test: correct test comment
Browse files Browse the repository at this point in the history
This corrects a comment on the signal type used in the test.

PR-URL: #38095
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
evanlucas authored and targos committed May 1, 2021
1 parent d6ab9bf commit f1aae43
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/abort/test-signal-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ if (process.argv[2] === 'child') {
const child = spawnSync(process.execPath,
['--expose-internals', __filename, 'child'],
{ stdio: 'inherit' });
// FreeBSD and macOS use SIGILL for the kind of crash we're causing here.
// FreeBSD uses SIGILL for this kind of crash.
// macOS uses SIGILL or SIGTRAP (arm64) for this kind of crash.
assert(child.signal === 'SIGSEGV' || child.signal === 'SIGILL' ||
child.signal === 'SIGTRAP', `child.signal = ${child.signal}`);
}

0 comments on commit f1aae43

Please sign in to comment.