Skip to content

Commit

Permalink
crypto: fix regression on randomFillSync
Browse files Browse the repository at this point in the history
Signed-off-by: James M Snell <jasnell@gmail.com>

Fixes: #35722
PR-URL: #35723
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
  • Loading branch information
jasnell authored and BethGriggs committed Oct 21, 2020
1 parent 1efa870 commit f5acc2d
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/internal/crypto/random.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ function randomFillSync(buf, offset = 0, size) {

const job = new RandomBytesJob(
kCryptoJobSync,
buf.buffer || buf,
buf,
offset,
size);

Expand Down
18 changes: 18 additions & 0 deletions test/parallel/test-crypto-randomfillsync-regression.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

const { randomFillSync } = require('crypto');
const { notStrictEqual } = require('assert');

const ab = new ArrayBuffer(20);
const buf = Buffer.from(ab, 10);

const before = buf.toString('hex');

randomFillSync(buf);

const after = buf.toString('hex');

notStrictEqual(before, after);

0 comments on commit f5acc2d

Please sign in to comment.