Skip to content

Commit

Permalink
test: use JSON.stringify to trigger stack overflow
Browse files Browse the repository at this point in the history
V8's interpreter performs stack checks both at the call site and at the
function entry. A recursive function could therefore trigger stack
overflow at two different source locations. Instead of recursion, call
JSON.stringify on a deeply nested array.

PR-URL: #12481
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
hashseed authored and evanlucas committed May 2, 2017
1 parent e77f1e2 commit f84a5e1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
10 changes: 6 additions & 4 deletions test/message/stack_overflow.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ Error.stackTraceLimit = 0;

console.error('before');

// stack overflow
function stackOverflow() {
stackOverflow();
// Trigger stack overflow by stringifying a deeply nested array.
let array = [];
for (let i = 0; i < 100000; i++) {
array = [ array ];
}
stackOverflow();

JSON.stringify(array);

console.error('after');
6 changes: 3 additions & 3 deletions test/message/stack_overflow.out
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
before

*test*message*stack_overflow.js:*
function stackOverflow() {
^
JSON.stringify(array);
^

RangeError: Maximum call stack size exceeded

0 comments on commit f84a5e1

Please sign in to comment.