stream: allow calling callback before promise

Refs: #39535
nodejs · Nov 10, 2021 · f8e42d2 · f8e42d2
1 parent 0a62026
commit f8e42d2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/lib/internal/streams/destroy.js b/lib/internal/streams/destroy.js
@@ -292,10 +292,14 @@ function constructNT(stream) {
         then.call(
           result,
           function() {
-            process.nextTick(onConstruct, null);
+            if (!called) {
+              process.nextTick(onConstruct, null);
+            }
           },
           function(err) {
-            process.nextTick(onConstruct, err);
+            if (!called) {
+              process.nextTick(onConstruct, err);
+            }
           });
       }
     }

diff --git a/lib/internal/streams/writable.js b/lib/internal/streams/writable.js
@@ -699,10 +699,14 @@ function callFinal(stream, state) {
         then.call(
           result,
           function() {
-            process.nextTick(onFinish, null);
+            if (!called) {
+              process.nextTick(onFinish, null);
+            }
           },
           function(err) {
-            process.nextTick(onFinish, err);
+            if (!called) {
+              process.nextTick(onFinish, err);
+            }
           });
       }
     }