Skip to content

Commit

Permalink
build: compile bundled simdutf conditionally
Browse files Browse the repository at this point in the history
The --shared-simdutf flag was introduced in #52924, but the
implementation was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
  • Loading branch information
jirutka authored and aduh95 committed Nov 26, 2024
1 parent d8eb83c commit fffabca
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
9 changes: 3 additions & 6 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,6 @@
'dependencies': [
'deps/googletest/googletest.gyp:gtest_prod',
'deps/histogram/histogram.gyp:histogram',
'deps/simdutf/simdutf.gyp:simdutf',
'deps/nbytes/nbytes.gyp:nbytes',
'node_js2c#host',
],
Expand Down Expand Up @@ -1170,7 +1169,6 @@
'deps/googletest/googletest.gyp:gtest',
'deps/googletest/googletest.gyp:gtest_main',
'deps/histogram/histogram.gyp:histogram',
'deps/simdutf/simdutf.gyp:simdutf',
'deps/nbytes/nbytes.gyp:nbytes',
],

Expand Down Expand Up @@ -1322,9 +1320,6 @@
'target_name': 'node_js2c',
'type': 'executable',
'toolsets': ['host'],
'dependencies': [
'deps/simdutf/simdutf.gyp:simdutf#host',
],
'include_dirs': [
'tools',
'src',
Expand All @@ -1336,6 +1331,9 @@
'src/embedded_data.cc',
],
'conditions': [
[ 'node_shared_simdutf=="false"', {
'dependencies': [ 'deps/simdutf/simdutf.gyp:simdutf#host' ],
}],
[ 'node_shared_libuv=="false"', {
'dependencies': [ 'deps/uv/uv.gyp:libuv#host' ],
}],
Expand All @@ -1362,7 +1360,6 @@
'<(node_lib_target_name)',
'deps/histogram/histogram.gyp:histogram',
'deps/nbytes/nbytes.gyp:nbytes',
'deps/simdutf/simdutf.gyp:simdutf',
],

'includes': [
Expand Down
4 changes: 4 additions & 0 deletions node.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@
'dependencies': [ 'deps/simdjson/simdjson.gyp:simdjson' ],
}],

[ 'node_shared_simdutf=="false"', {
'dependencies': [ 'deps/simdutf/simdutf.gyp:simdutf' ],
}],

[ 'node_shared_brotli=="false"', {
'dependencies': [ 'deps/brotli/brotli.gyp:brotli' ],
}],
Expand Down

0 comments on commit fffabca

Please sign in to comment.