Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: really enable unbundling of simdjson, simdutf, ada #55886

Closed
wants to merge 3 commits into from
Closed

build: really enable unbundling of simdjson, simdutf, ada #55886

wants to merge 3 commits into from

Conversation

jirutka
Copy link
Contributor

@jirutka jirutka commented Nov 16, 2024

This is a follow-up for #52924 which was incomplete.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Nov 16, 2024
@jirutka
build: compile bundled ada conditionally
78bd0ab 
The --shared-ada flag was introduced in nodejs#52924, but the implementation
was incomplete.

Resolves nodejs#52914
@jirutka
build: compile bundled simdjson conditionally
077b553 
The --shared-simdjson flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914
@jirutka
build: compile bundled simdutf conditionally
4a035b3 
The --shared-simdutf flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Nov 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63599/

lpinca
lpinca approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63606/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2024
@nodejs-github-bot
Copy link
Collaborator

Landed in a8daa45...64c647e

nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2024
@jirutka @nodejs-github-bot
build: compile bundled ada conditionally
88719f6 
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2024
@jirutka @nodejs-github-bot
build: compile bundled simdjson conditionally
dd15563 
The --shared-simdjson flag was introduced in #52924, but the
implementation was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2024
@jirutka @nodejs-github-bot
build: compile bundled simdutf conditionally
64c647e 
The --shared-simdutf flag was introduced in #52924, but the
implementation was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@jirutka jirutka deleted the shared-deps branch November 18, 2024 21:00
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@jirutka @tpoisseau
build: compile bundled ada conditionally
466519b 
The --shared-ada flag was introduced in nodejs#52924, but the implementation
was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@jirutka @tpoisseau
build: compile bundled simdjson conditionally
ecf9759 
The --shared-simdjson flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@jirutka @tpoisseau
build: compile bundled simdutf conditionally
387d260 
The --shared-simdutf flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@jirutka @Ceres6
build: compile bundled ada conditionally
6566999 
The --shared-ada flag was introduced in nodejs#52924, but the implementation
was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@jirutka @Ceres6
build: compile bundled simdjson conditionally
2c7ff74 
The --shared-simdjson flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@jirutka @Ceres6
build: compile bundled simdutf conditionally
1e580bd 
The --shared-simdutf flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@jirutka @aduh95
build: compile bundled ada conditionally
83e02dc 
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@jirutka @aduh95
build: compile bundled simdjson conditionally
d8eb83c 
The --shared-simdjson flag was introduced in #52924, but the
implementation was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@jirutka @aduh95
build: compile bundled simdutf conditionally
fffabca 
The --shared-simdutf flag was introduced in #52924, but the
implementation was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Closed
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@jirutka @aduh95
build: compile bundled ada conditionally
50faa64 
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@jirutka @aduh95
build: compile bundled simdjson conditionally
e309310 
The --shared-simdjson flag was introduced in #52924, but the
implementation was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@jirutka @aduh95
build: compile bundled simdutf conditionally
f557c0e 
The --shared-simdutf flag was introduced in #52924, but the
implementation was incomplete.

Resolves #52914

PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
This was referenced Dec 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jirutka @nodejs-github-bot @lpinca @anonrig @richardlau @aduh95