Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-12-01, Version 23.4.0 (Current), @aduh95 #18

Closed
wants to merge 53 commits into from
Closed

Conversation

aduh95
Copy link
Owner

@aduh95 aduh95 commented Nov 28, 2024

2024-12-01, Version 23.4.0 (Current), @aduh95

Notable Changes

  • [a4f57f0293] - (SEMVER-MINOR) assert: add partialDeepStrictEqual (Giovanni Bucci) #54630
  • [efb9f05f59] - (SEMVER-MINOR) doc,lib,src,test: unflag sqlite module (Colin Ihrig) #55890
  • [d777d4a52d] - (SEMVER-MINOR) sqlite: add StatementSync.prototype.iterate method (tpoisseau) #54213

Commits

  • [5b0ce376a2] - assert: optimize partial comparison of two Sets (Antoine du Hamel) #55970
  • [a4f57f0293] - (SEMVER-MINOR) assert: add partialDeepStrictEqual (Giovanni Bucci) #54630
  • [7133c0459f] - build: avoid compiling with VS v17.12 (Stefan Stojanovic) #55930
  • [ce53f1689f] - build: set node_arch to target_cpu in GN (Shelley Vohr) #55967
  • [2023b09d27] - build: add create release proposal action (Rafael Gonzaga) #55690
  • [26ec99634c] - build: use variable for crypto dep path (Shelley Vohr) #55928
  • [f48e289580] - build: fix GN build for sqlite (Cheng) #55912
  • [fffabca6b8] - build: compile bundled simdutf conditionally (Jakub Jirutka) #55886
  • [d8eb83c5c5] - build: compile bundled simdjson conditionally (Jakub Jirutka) #55886
  • [83e02dc482] - build: compile bundled ada conditionally (Jakub Jirutka) #55886
  • [93d36bf1c8] - crypto: allow non-multiple of 8 in SubtleCrypto.deriveBits (Filip Skokan) #55296
  • [f99f95f62f] - deps: update corepack to 0.30.0 (Node.js GitHub Bot) #55977
  • [96e846de89] - deps: update ngtcp2 to 1.9.0 (Node.js GitHub Bot) #55975
  • [d180a8aedb] - deps: update simdutf to 5.6.3 (Node.js GitHub Bot) #55973
  • [288416a764] - deps: upgrade npm to 10.9.1 (npm team) #55951
  • [cf3f7ac512] - deps: update zlib to 1.3.0.1-motley-7e2e4d7 (Node.js GitHub Bot) #54432
  • [7768b3d054] - deps: update simdjson to 3.10.1 (Node.js GitHub Bot) #54678
  • [9c6103833b] - deps: update simdutf to 5.6.2 (Node.js GitHub Bot) #55889
  • [baed2763df] - doc: deprecate passing invalid types in fs.existsSync (Carlos Espa) #55892
  • [a3f7db6b6d] - doc: add doc for PerformanceObserver.takeRecords() (skyclouds2001) #55786
  • [770572423b] - doc: add vetted courses to the ambassador benefits (Matteo Collina) #55934
  • [98f8f4a8a9] - doc: order node:crypto APIs alphabetically (Julian Gassner) #55831
  • [1e0decb44c] - doc: doc how to add message for promotion (Michael Dawson) #55843
  • [ff48c29724] - doc: add esm example for zlib (Leonardo Peixoto) #55946
  • [ccc5a6d552] - doc: document approach for building wasm in deps (Michael Dawson) #55940
  • [c8bb8a6ac5] - doc: fix Node.js 23 column in CHANGELOG.md (Richard Lau) #55935
  • [9d078802ad] - doc: remove RedYetiDev from triagers team (Aviv Keller) #55947
  • [5a2a757119] - doc: add esm examples to node:timers (Alfredo González) #55857
  • [f711a48e15] - doc: fix relative path mention in --allow-fs (Rafael Gonzaga) #55791
  • [219f5f2627] - doc: include git node release --promote to steps (Rafael Gonzaga) #55835
  • [f9d25ed3e4] - doc: add history entry for import assertion removal (Antoine du Hamel) #55883
  • [efb9f05f59] - (SEMVER-MINOR) doc,lib,src,test: unflag sqlite module (Colin Ihrig) #55890
  • [9289374248] - http2: fix memory leak caused by premature listener removing (ywave620) #55966
  • [30f26ba254] - lib: avoid excluding symlinks in recursive fs.readdir with filetypes (Juan José) #55714
  • [4be5047030] - module: do not warn when require(esm) comes from node_modules (Joyee Cheung) #55960
  • [1fb30d6e86] - quic: multiple updates to quic impl (James M Snell) #55971
  • [d777d4a52d] - (SEMVER-MINOR) sqlite: add StatementSync.prototype.iterate method (tpoisseau) #54213
  • [971f5f54df] - src: safely remove the last line from dotenv (Shima Ryuhei) #55982
  • [497a9aea1c] - src: fix kill signal on Windows (Hüseyin Açacak) #55514
  • [f7567d46d8] - test: make HTTP/1.0 connection test more robust (Arne Keller) #55959
  • [c157e026fc] - test: convert readdir test to use test runner (Thomas Chetwin) #55750
  • [29362ce673] - test: make x509 crypto tests work with BoringSSL (Shelley Vohr) #55927
  • [493e16c852] - test: fix determining lower priority (Livia Medeiros) #55908
  • [7c3a4d4bcd] - test_runner: refactor Promise chain in run() (Colin Ihrig) #55958
  • [95e8c4ef6c] - test_runner: refactor build Promise in Suite() (Colin Ihrig) #55958
  • [c048865199] - test_runner: simplify hook running logic (Colin Ihrig) #55963
  • [8197815fe8] - test_runner: mark snapshot testing as stable (Colin Ihrig) #55897
  • [8a5d8c7669] - test_runner: mark context.plan() as stable (Colin Ihrig) #55895
  • [32b1681b7f] - tools: use tokenless Codecov uploads (Michaël Zasso) #55943
  • [475141e370] - tools: add linter for release commit proposals (Antoine du Hamel) #55923
  • [d093820f64] - tools: lint js in doc/**/*.md (Livia Medeiros) #55904
  • [72eb710f0f] - tools: fix riscv64 build failed (Lu Yahan) #52888
  • [882b70c83f] - tools: bump cross-spawn from 7.0.3 to 7.0.5 in /tools/eslint (dependabot[bot]) #55894

dependabot bot and others added 30 commits November 26, 2024 15:34
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.5.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.5)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: nodejs#55894
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: nodejs#52888
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#55883
Refs: nodejs#52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
The --shared-ada flag was introduced in nodejs#52924, but the implementation
was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
The --shared-simdjson flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
The --shared-simdutf flag was introduced in nodejs#52924, but the
implementation was incomplete.

Resolves nodejs#52914

PR-URL: nodejs#55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#55889
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This commit allows the node:sqlite module to be used without
starting Node with a CLI flag. The module is still experimental.

Fixes: nodejs#55854
PR-URL: nodejs#55890
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This function does not require a CLI flag, does not emit a warning,
and is a fairly simple API that is already being used heavily in
the ecosystem. This commit marks context.plan() as stable.

PR-URL: nodejs#55895
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This commit marks the test runner's snapshot testing API as
stable.

PR-URL: nodejs#55897
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Refs: nodejs/node-core-utils#835
PR-URL: nodejs#55835
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: nodejs#55791
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: nodejs#55904
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fixes: nodejs#42923
PR-URL: nodejs#55514
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
PR-URL: nodejs#55908
Fixes: NixOS/nixpkgs#355919
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#55857
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#55912
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#54678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#55947
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#54213
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#55927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The column for Node.js 23 in `CHANGELOG.md` is missing an opening
`<td>` tag so was not correctly rendering.

PR-URL: nodejs#55935
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#55923
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Refs: nodejs/security-wg#1236

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#55940
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#55928
Reviewed-By: Cheng Zhao <zcbenz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
As part of the standard experimental feature graduation
policy, when we unflagged require(esm) we moved the
experimental warning to be emitted when require() is
actually used to load ESM, which previously was an error.
However, some packages in the ecosystem have already
being using try-catch to load require(esm) to e.g.
resolve optional dependency, and emitting warning from
there instead of throwing directly could break the CLI
output.

To reduce the disruption for releases, as a compromise, this
patch skips the warning if require(esm) comes from
node_modules, where users typically don't have much control
over the code. This warning will be eventually removed
when require(esm) becomes stable.

This patch was originally intended for the LTS releases,
though it seems there's appetite for it on v23.x as
well so it's re-targeted to the main branch.

PR-URL: nodejs#55960
Refs: nodejs#55217
Refs: nodejs#52697
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: nodejs#55946
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#54432
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#55296
Reviewed-By: James M Snell <jasnell@gmail.com>
Document the process for adding a message that
ambassadors will be asked to promote.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#55843
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
mcollina and others added 12 commits November 26, 2024 15:34
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: nodejs#55934
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#55786
Fixes: nodejs#55779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
PR-URL: nodejs#55970
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#55892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
* separate stats and symbols into separate files
* quic: rename `EndpointStats` and `SessionStats` to be consistent
  * s/EndpointStats/QuicEndpointStats/
  * s/SessionStats/QuicSessionStats/
* separate state into separate files and other cleanups
* extend tls options validations
* rename classes for consistency and other cleanups

PR-URL: nodejs#55971
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#55973
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: nodejs#55975
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: nodejs#55977
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Http2Session should always call ondone into JS to detach the
handle. In some case, ondone is defered to be called by the
StreamListener through WriteWrap, we should be careful of this
before getting rid of the StreamListener.

PR-URL: nodejs#55966
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: nodejs#55967
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Refs: nodejs/build#3963
PR-URL: nodejs#55930
Refs: nodejs#53863
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: nodejs#55925
PR-URL: nodejs#55982
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@aduh95 aduh95 closed this Nov 28, 2024
@aduh95 aduh95 deleted the v23.4.0-proposal branch November 28, 2024 00:52
@aduh95 aduh95 restored the v23.4.0-proposal branch November 28, 2024 00:53
@aduh95 aduh95 deleted the v23.4.0-proposal branch November 28, 2024 00:54
@aduh95 aduh95 restored the v23.4.0-proposal branch November 28, 2024 11:38
@aduh95 aduh95 deleted the v23.4.0-proposal branch November 28, 2024 11:50
@aduh95 aduh95 restored the v23.4.0-proposal branch November 28, 2024 12:59
@aduh95 aduh95 deleted the v23.4.0-proposal branch November 28, 2024 13:11
@aduh95 aduh95 restored the v23.4.0-proposal branch November 28, 2024 13:11
@aduh95 aduh95 deleted the v23.4.0-proposal branch November 28, 2024 13:16
@aduh95 aduh95 restored the v23.4.0-proposal branch November 28, 2024 13:17
@aduh95 aduh95 deleted the v23.4.0-proposal branch November 28, 2024 13:21
@aduh95 aduh95 restored the v23.4.0-proposal branch November 28, 2024 13:22
@aduh95 aduh95 deleted the v23.4.0-proposal branch November 28, 2024 14:10
@aduh95 aduh95 restored the v23.4.0-proposal branch November 28, 2024 14:11
@aduh95 aduh95 deleted the v23.4.0-proposal branch November 28, 2024 14:39
@github-actions github-actions bot restored the v23.4.0-proposal branch November 28, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.