test_runner: mark snapshot testing as stable #55897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55897 +/- ##
==========================================
+ Coverage 87.93% 88.43% +0.50%
==========================================
Files 654 654
Lines 187860 187853 -7
Branches 35840 36147 +307
==========================================
+ Hits 165196 166131 +935
+ Misses 15863 14973 -890
+ Partials 6801 6749 -52
|
MoLow
reviewed
Nov 17, 2024
MoLow
approved these changes
Nov 17, 2024
This commit marks the test runner's snapshot testing API as stable.
cjihrig
force-pushed
the
test-snapshots
branch
from
9f94003
to
78b974b
Compare
MoLow
approved these changes
Nov 17, 2024
pmarchini
approved these changes
Nov 17, 2024
github-actions
bot
removed
the
request-ci
cjihrig
added
author ready
JakobJingleheimer
approved these changes
Nov 18, 2024
atlowChemi
approved these changes
Nov 19, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in c921676 |
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
This commit marks the test runner's snapshot testing API as stable. PR-URL: nodejs#55897 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
This commit marks the test runner's snapshot testing API as stable. PR-URL: nodejs#55897 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
This commit marks the test runner's snapshot testing API as stable. PR-URL: #55897 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit marks the test runner's snapshot testing API as stable.
Snapshot testing has been available for over 5 months. There are no open issues related to it.