Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: order crypto methods alphabetically #55831

Merged
merged 7 commits into from
Nov 23, 2024
Merged

doc: order crypto methods alphabetically #55831

merged 7 commits into from
Nov 23, 2024

Conversation

badkeyy
Copy link
Contributor

@badkeyy badkeyy commented Nov 13, 2024

Fixes #55801

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Nov 13, 2024
@aduh95
Copy link
Contributor

aduh95 commented Nov 13, 2024

While we're at it:

@aduh95
Copy link
Contributor

aduh95 commented Nov 13, 2024

I've found some more who are out of order:

  • crypto.constants
  • crypto.checkPrime(candidate[, options], callback)
  • crypto.randomFillSync(buffer[, offset][, size])

FWIW, here's the script I've used, so we can be confident we're forgetting any:

$0.querySelectorAll('ul').forEach(ul => console.log(Array.from(ul.children, li => li.textContent.split('(', 1)[0]).find((t, i, l) => t < l[i-1])))

If you can push one commit per section that you move, that would make reviewing easier :)

aduh95
aduh95 reviewed Nov 20, 2024
View reviewed changes
doc/api/crypto.md Outdated Show resolved Hide resolved
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 23, 2024
@aduh95 aduh95 merged commit a2a0c22 into nodejs:main Nov 23, 2024
25 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Nov 23, 2024

Landed in a2a0c22

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@badkeyy @Ceres6
doc: order node:crypto APIs alphabetically
ab6427d 
PR-URL: nodejs#55831
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@badkeyy @aduh95
doc: order node:crypto APIs alphabetically
98f8f4a 
PR-URL: #55831
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Open
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disordered position of the crypto.hash
4 participants
@badkeyy @nodejs-github-bot @aduh95 @jasnell