doc,lib,src,test: unflag sqlite module #55890

cjihrig · 2024-11-17T03:13:47Z

As requested in #55854...

This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental.

Fixes: #55854

codecov · 2024-11-17T04:24:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (746b17e) to head (a54b0ac).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55890      +/-   ##
==========================================
- Coverage   88.41%   88.41%   -0.01%     
==========================================
  Files         654      654              
  Lines      188036   188036              
  Branches    36187    36182       -5     
==========================================
- Hits       166260   166257       -3     
- Misses      14989    14990       +1     
- Partials     6787     6789       +2

Files with missing lines	Coverage Δ
lib/internal/process/pre_execution.js	`90.56% <100.00%> (+0.14%)`	⬆️
src/node_options.cc	`87.46% <ø> (ø)`
src/node_options.h	`98.27% <100.00%> (ø)`

... and 38 files with indirect coverage changes

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

nodejs-github-bot · 2024-11-17T17:20:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63605/ 🟡

This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: nodejs#55854

cjihrig · 2024-11-18T13:43:59Z

Rebased to fix a minor conflict in the docs from #54181.

nodejs-github-bot · 2024-11-18T13:46:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63618/

mcollina

lgtm

github-actions · 2024-11-18T14:23:23Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

nodejs-github-bot · 2024-11-18T22:18:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63623/

nodejs-github-bot · 2024-11-18T23:15:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63625/

nodejs-github-bot · 2024-11-19T03:23:19Z

Landed in 1d01ad6

This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: nodejs#55854 PR-URL: nodejs#55890 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: #55854 PR-URL: #55890 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #25

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #26

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #27

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #28

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL:

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) nodejs#54630 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) nodejs#55890 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) nodejs#54213 PR-URL: #30

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: TODO

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Nov 17, 2024

jakecastelli approved these changes Nov 17, 2024

View reviewed changes

marco-ippolito approved these changes Nov 17, 2024

View reviewed changes

RedYetiDev added the sqlite Issues and PRs related to the SQLite subsystem. label Nov 17, 2024

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 17, 2024

MoLow approved these changes Nov 17, 2024

View reviewed changes

cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Nov 18, 2024

targos approved these changes Nov 18, 2024

View reviewed changes

doc,lib,src,test: unflag sqlite module

a54b0ac

This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: nodejs#55854

cjihrig force-pushed the unflag-sqlite branch from de77663 to a54b0ac Compare November 18, 2024 13:43

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2024

mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 18, 2024

mcollina approved these changes Nov 18, 2024

View reviewed changes

marco-ippolito added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 18, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2024

nodejs-github-bot merged commit 1d01ad6 into nodejs:main Nov 19, 2024
63 checks passed

cjihrig deleted the unflag-sqlite branch November 19, 2024 03:23

github-actions bot mentioned this pull request Nov 28, 2024

2024-12-01, Version 23.4.0 (Current), @aduh95 aduh95/node#26

Closed

github-actions bot mentioned this pull request Nov 28, 2024

2024-12-01, Version 23.4.0 (Current), @aduh95 aduh95/node#27

Closed

github-actions bot mentioned this pull request Nov 28, 2024

2024-12-01, Version 23.4.0 (Current), @aduh95 aduh95/node#28

Closed

github-actions bot mentioned this pull request Nov 30, 2024

2024-12-01, Version 23.4.0 (Current), @aduh95 aduh95/node#29

Closed

github-actions bot mentioned this pull request Nov 30, 2024

2024-12-01, Version 23.4.0 (Current), @aduh95 aduh95/node#30

Open

nodejs-github-bot mentioned this pull request Dec 3, 2024

2024-12-04, Version 23.4.0 (Current), @targos #56119

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc,lib,src,test: unflag sqlite module #55890

doc,lib,src,test: unflag sqlite module #55890

cjihrig commented Nov 17, 2024

codecov bot commented Nov 17, 2024 •

edited

Loading

nodejs-github-bot commented Nov 17, 2024 •

edited by cjihrig

Loading

cjihrig commented Nov 18, 2024

nodejs-github-bot commented Nov 18, 2024

mcollina left a comment

github-actions bot commented Nov 18, 2024

nodejs-github-bot commented Nov 18, 2024

nodejs-github-bot commented Nov 18, 2024

nodejs-github-bot commented Nov 19, 2024

doc,lib,src,test: unflag sqlite module #55890

doc,lib,src,test: unflag sqlite module #55890

Conversation

cjihrig commented Nov 17, 2024

codecov bot commented Nov 17, 2024 • edited Loading

Codecov Report

nodejs-github-bot commented Nov 17, 2024 • edited by cjihrig Loading

cjihrig commented Nov 18, 2024

nodejs-github-bot commented Nov 18, 2024

mcollina left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 18, 2024

nodejs-github-bot commented Nov 18, 2024

nodejs-github-bot commented Nov 18, 2024

nodejs-github-bot commented Nov 19, 2024

codecov bot commented Nov 17, 2024 •

edited

Loading

nodejs-github-bot commented Nov 17, 2024 •

edited by cjihrig

Loading