process: deprecate features.{ipv6,uv} and features.tls_*
#55545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedYetiDev
reviewed
Oct 26, 2024
RedYetiDev
added
semver-minor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Renegade334
force-pushed
the
process-features-deprecations
branch
from
5d4b6ac
to
cab3955
Compare
marco-ippolito
approved these changes
Oct 26, 2024
doc/api/process.md
Outdated
| * {boolean} | ||
|
|
||
| A boolean value that is `true` if the current Node.js build includes support for SNI in TLS. | ||
|
|
||
| Since OpenSSL now unconditionally supports SNI, this value is identical to that of |
There was a problem hiding this comment.
the word now is ephemeral and may not be good at API doc, can you pls use something like `since vx.y or similar?
jasnell
approved these changes
Nov 5, 2024
Renegade334
force-pushed
the
process-features-deprecations
branch
from
cab3955
to
83a3673
Compare
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55545
✔ Done loading data for nodejs/node/pull/55545
----------------------------------- PR info ------------------------------------
Title process: deprecate `features.{ipv6,uv}` and `features.tls_*` (#55545)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch Renegade334:process-features-deprecations -> nodejs:main
Labels doc, semver-minor, process, notable-change, deprecations
Commits 1
- process: deprecate `features.{ipv6,uv}` and `features.tls_*`
Committers 1
- Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: https://github.com/nodejs/node/pull/55545
Fixes: https://github.com/nodejs/node/issues/55537
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55545
Fixes: https://github.com/nodejs/node/issues/55537
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - process: deprecate `features.{ipv6,uv}` and `features.tls_*`
ℹ This PR was created on Sat, 26 Oct 2024 00:41:37 GMT
✔ Approvals: 2
✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/55545#pullrequestreview-2397228627
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55545#pullrequestreview-2416975224
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11988131607 |
|
Ah, node-core-utils, we meet again. Should now be happy. |
juanarbol
approved these changes
Nov 27, 2024
juanarbol
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ae8280c |
|
Fix in #56018 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: TODO
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119
targos
pushed a commit
that referenced
this pull request
Dec 3, 2024
Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 net: * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 sqlite: * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 PR-URL: #56119
github-actions bot
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#55545 Fixes: nodejs#55537 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#55545 Fixes: nodejs#55537 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#55545 Fixes: nodejs#55537 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #55537
As per the linked issue.
ipv6anduvare unconditionally true, and have been since v0.5.x.tls_*properties. Since v11.0.0, this is no longer the case, and so these properties are now redundant.