tools: use tokenless Codecov uploads #55943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
anonrig
approved these changes
Nov 21, 2024
richardlau
approved these changes
Nov 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55943 +/- ##
==========================================
- Coverage 87.99% 87.99% -0.01%
==========================================
Files 653 653
Lines 188091 188091
Branches 35941 35947 +6
==========================================
- Hits 165516 165515 -1
+ Misses 15751 15742 -9
- Partials 6824 6834 +10
|
lpinca
approved these changes
Nov 21, 2024
juanarbol
approved these changes
Nov 22, 2024
jasnell
approved these changes
Nov 23, 2024
targos
force-pushed
the
codecov-tokenless
branch
from
603dc9e to
22f5f49
Compare
|
Rebased to reset the |
richardlau
approved these changes
Nov 24, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ce346b6 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token PR-URL: nodejs#55943 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token PR-URL: #55943 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token
I already enabled it in the Codecov settings for the
nodejsorg.