module: do not warn when require(esm) comes from node_modules #55960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the standard experimental feature graduation policy, when we unflagged require(esm) we moved the experimental warning to be emitted when require() is actually used to load ESM, which previously was an error. However, some packages in the ecosystem have already being using try-catch to load require(esm) to e.g. resolve optional dependency, and emitting warning from there instead of throwing directly could break the CLI output. To reduce the disruption for releases, as a compromise, this patch skips the warning if require(esm) comes from node_modules, where users typically don't have much control over the code. This warning will be eventually removed when require(esm) becomes stable. This patch was originally intended for the LTS releases, though it seems there's appetite for it on v23.x as well so it's re-targeted to the main branch.
|
Review requested:
|
nodejs-github-bot
added
module
github-actions
bot
removed
the
request-ci
joyeecheung
added
request-ci
|
Not sure it needs a fast-track, though it was already reviewed and approved before in #55217 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55960 +/- ##
==========================================
- Coverage 88.01% 87.99% -0.02%
==========================================
Files 653 653
Lines 187735 187872 +137
Branches 35874 35888 +14
==========================================
+ Hits 165229 165318 +89
- Misses 15693 15723 +30
- Partials 6813 6831 +18
|
aduh95
approved these changes
Nov 23, 2024
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
JakobJingleheimer
approved these changes
Nov 23, 2024
joyeecheung
added
the
commit-queue
Seems unnecessary to revert (and would be introducing backport conflicts) if it's going to be on both 23 and 22, at most we still get extra warnings on nightlies if we revert which doesn't seem super...useful? |
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1919560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the standard experimental feature graduation policy, when we unflagged require(esm) we moved the experimental warning to be emitted when require() is actually used to load ESM, which previously was an error. However, some packages in the ecosystem have already being using try-catch to load require(esm) to e.g. resolve optional dependency, and emitting warning from there instead of throwing directly could break the CLI output.
To reduce the disruption for releases, as a compromise, this patch skips the warning if require(esm) comes from node_modules, where users typically don't have much control over the code. This warning will be eventually removed when require(esm) becomes stable.
This patch was originally intended for the LTS releases (originally in #55217), though it seems there's appetite for it on v23.x as well so it's re-targeted to the main branch.
Refs: #55217
Refs: #52697