test: make x509 crypto tests work with BoringSSL #55927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55927 +/- ##
==========================================
+ Coverage 88.01% 88.49% +0.48%
==========================================
Files 653 653
Lines 187735 187728 -7
Branches 35874 36183 +309
==========================================
+ Hits 165229 166137 +908
+ Misses 15693 14818 -875
+ Partials 6813 6773 -40
|
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Nov 20, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Livia Medeiros <livia@cirno.name>
Co-authored-by: Livia Medeiros <livia@cirno.name>
Co-authored-by: Livia Medeiros <livia@cirno.name>
LiviaMedeiros
approved these changes
Nov 20, 2024
lpinca
approved these changes
Nov 20, 2024
LiviaMedeiros
added
the
author ready
codebytere
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55927 ✔ Done loading data for nodejs/node/pull/55927 ----------------------------------- PR info ------------------------------------ Title test: make x509 crypto tests work with BoringSSL (#55927) Author Shelley Vohr <shelley.vohr@gmail.com> (@codebytere) Branch codebytere:upstream-boringssl-x509-compat -> nodejs:main Labels test, author ready Commits 4 - test: make x509 crypto tests work with BoringSSL - Update test/parallel/test-crypto-x509.js - Update test/parallel/test-crypto-x509.js - Update test/parallel/test-crypto-x509.js Committers 2 - Shelley Vohr <shelley.vohr@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/55927 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55927 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 20 Nov 2024 09:16:37 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/55927#pullrequestreview-2448627030 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/55927#pullrequestreview-2448822391 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55927#pullrequestreview-2449682404 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-11-20T14:41:40Z: https://ci.nodejs.org/job/node-test-pull-request/63640/ - Querying data for job/node-test-pull-request/63640/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 55927 From https://github.com/nodejs/node * branch refs/pull/55927/merge -> FETCH_HEAD ✔ Fetched commits as ead8bd157a94..12e14d86d35b -------------------------------------------------------------------------------- [main 6fd53725ee] test: make x509 crypto tests work with BoringSSL Author: Shelley Vohr <shelley.vohr@gmail.com> Date: Tue Nov 19 14:25:37 2024 +0100 1 file changed, 16 insertions(+), 14 deletions(-) [main fe330968bd] Update test/parallel/test-crypto-x509.js Author: Shelley Vohr <shelley.vohr@gmail.com> Date: Wed Nov 20 15:37:28 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 881454a9a3] Update test/parallel/test-crypto-x509.js Author: Shelley Vohr <shelley.vohr@gmail.com> Date: Wed Nov 20 15:37:36 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main 643442c061] Update test/parallel/test-crypto-x509.js Author: Shelley Vohr <shelley.vohr@gmail.com> Date: Wed Nov 20 15:38:01 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: make x509 crypto tests work with BoringSSLhttps://github.com/nodejs/node/actions/runs/11969824102 |
LiviaMedeiros
added
needs-ci
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3178a76 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55927 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55927 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2024
PR-URL: #55927 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title. Tweaks a few checks
parallel/test-crypto-x509.jsin so they work with BoringSSL