doc: fix Node.js 23 column in CHANGELOG.md #55935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
added
dont-land-on-v18.x
nodejs-github-bot
added
the
meta
anonrig
approved these changes
Nov 20, 2024
|
FWIW this affects v23.x but @RafaelGSS I do not think this is worth holding up #55921 for (i.e. this can land separately for the next 23.x release). |
aduh95
approved these changes
Nov 20, 2024
richardlau
added
the
author ready
RafaelGSS
approved these changes
Nov 20, 2024
aduh95
added
the
commit-queue
jazelly
approved these changes
Nov 20, 2024
The column for Node.js 23 in `CHANGELOG.md` is missing an opening `<td>` tag so was not correctly rendering.
richardlau
force-pushed
the
changelog
branch
from
b716a27
to
f386574
Compare
LiviaMedeiros
approved these changes
Nov 21, 2024
marco-ippolito
approved these changes
Nov 21, 2024
lpinca
approved these changes
Nov 21, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 05b3fcb |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
The column for Node.js 23 in `CHANGELOG.md` is missing an opening `<td>` tag so was not correctly rendering. PR-URL: nodejs#55935 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
The column for Node.js 23 in `CHANGELOG.md` is missing an opening `<td>` tag so was not correctly rendering. PR-URL: #55935 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column for Node.js 23 in
CHANGELOG.mdis missing an opening<td>tag so was not correctly rendering.Before
After
