test_runner: simplify hook running logic #55963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes some asynchronous logic from the runHook() method and replaces ArrayPrototypeReduce() with a for loop.
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55963 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 653 653
Lines 187852 187852
Branches 35888 35886 -2
=======================================
+ Hits 165295 165306 +11
+ Misses 15729 15724 -5
+ Partials 6828 6822 -6
|
pmarchini
approved these changes
Nov 23, 2024
jasnell
approved these changes
Nov 23, 2024
atlowChemi
approved these changes
Nov 23, 2024
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Nov 23, 2024
aduh95
added
the
author ready
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b09618e |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
This commit removes some asynchronous logic from the runHook() method and replaces ArrayPrototypeReduce() with a for loop. PR-URL: nodejs#55963 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
This commit removes some asynchronous logic from the runHook() method and replaces ArrayPrototypeReduce() with a for loop. PR-URL: #55963 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some asynchronous logic from the
runHook()method and replacesArrayPrototypeReduce()with aforloop.