src: fix kill signal on Windows #55514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
huseyinacacak-janea
force-pushed
the
huseyin-10409-process-kill-signal
branch
from
070e103
to
3eaa41f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55514 +/- ##
==========================================
- Coverage 88.40% 88.40% -0.01%
==========================================
Files 653 654 +1
Lines 187437 187747 +310
Branches 36073 36126 +53
==========================================
+ Hits 165711 165978 +267
- Misses 14956 15006 +50
+ Partials 6770 6763 -7
|
lpinca
approved these changes
Oct 24, 2024
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
jasnell
reviewed
Nov 5, 2024
|
|
||
| // Test different types of kill signals on Windows. | ||
| if (common.isWindows) { | ||
| const process1 = spawn('cmd'); |
There was a problem hiding this comment.
Can this be simplified down to a for loop of test cases?
There was a problem hiding this comment.
Thank you for the review. Fixed it.
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
|
Is there anything else I can do to help this PR move forward? |
richardlau
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55514 ✔ Done loading data for nodejs/node/pull/55514 ----------------------------------- PR info ------------------------------------ Title src: fix kill signal on Windows (#55514) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch huseyinacacak-janea:huseyin-10409-process-kill-signal -> nodejs:main Labels child_process, c++, needs-ci, commit-queue-squash Commits 4 - src: fix kill signal on Windows - Update doc/api/child_process.md - Update test/parallel/test-child-process-kill.js - fixup! src: fix kill signal on Windows Committers 2 - Hüseyin Açacak <huseyin@janeasystems.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/55514 Fixes: https://github.com/nodejs/node/issues/42923 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55514 Fixes: https://github.com/nodejs/node/issues/42923 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update doc/api/child_process.md ⚠ - Update test/parallel/test-child-process-kill.js ⚠ - fixup! src: fix kill signal on Windows ℹ This PR was created on Thu, 24 Oct 2024 10:31:09 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55514#pullrequestreview-2393535306 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-11-12T10:37:04Z: https://ci.nodejs.org/job/node-test-pull-request/63526/ - Querying data for job/node-test-pull-request/63526/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11893278060 |
StefanStojanovic
approved these changes
Nov 20, 2024
StefanStojanovic
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eb1cb36 |
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Fixes: nodejs#42923 PR-URL: nodejs#55514 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
Fixes: nodejs#42923 PR-URL: nodejs#55514 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the documentation of Node.js, the
signalparameter of child processkillfunction is ignored.However, when we execute
spawn(process.execPath, ['-v']).kill('SIGHUP');, it throws an exception with the codeENOSYS. This is not consistent with the documentation.I've looked at the implementation in libuv and have seen that only four signal types are supported to kill a process on Windows.
This PR fixes this issue by changing the signal to
SIGKILLif it differs fromSIGQUIT,SIGTERM,SIGKILL, andSIGINT. In addition, there is a slight change in the documentation to clarify thesignalparameter.Fixes: #42923