Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-https-set-timeout-server on freebsd #10130

Closed
mhdawson opened this issue Dec 5, 2016 · 9 comments
Closed

test-https-set-timeout-server on freebsd #10130

mhdawson opened this issue Dec 5, 2016 · 9 comments
Labels
freebsd Issues and PRs related to the FreeBSD platform. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Comments

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2016

  • Version: master
  • Platform: freebsd10-64
  • Subsystem:https

Failure seen when running test against a PR changing a different test:

https://ci.nodejs.org/job/node-test-commit-freebsd/5673/nodes=freebsd10-64/

not ok 614 parallel/test-https-set-timeout-server
  ---
  duration_ms: 1.645
  severity: fail
  stack: |-
    # serverTimeout
    # serverRequestTimeout
    # serverResponseTimeout
    # serverRequestNotTimeoutAfterEnd
    # serverResponseTimeoutWithPipeline
    # idleTimeout
    ok
    Mismatched <anonymous> function calls. Expected 1, actual 0.
        at idleTimeout (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-https-set-timeout-server.js:149:42)
        at run (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-https-set-timeout-server.js:31:5)
        at Server.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-https-set-timeout-server.js:131:5)
        at emitOne (events.js:96:13)
        at Server.emit (events.js:188:7)
        at TLSSocket.<anonymous> (_http_server.js:314:30)
        at emitNone (events.js:86:13)
        at TLSSocket.emit (events.js:185:7)
        at TLSSocket.Socket._onTimeout (net.js:342:8)
  ...
@mhdawson mhdawson added the test Issues and PRs related to the tests. label Dec 5, 2016
@mhdawson
Copy link
Member Author

mhdawson commented Dec 5, 2016

Looking at history don't see any recent changes to the test.

@mhdawson mhdawson mentioned this issue Dec 5, 2016
Closed
2 tasks
@mscdex mscdex added freebsd Issues and PRs related to the FreeBSD platform. https Issues or PRs related to the https subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Dec 5, 2016
@mhdawson
Copy link
Member Author

mhdawson commented Dec 5, 2016

Failed again here: https://ci.nodejs.org/job/node-test-commit-freebsd/5675/nodes=freebsd10-64/console

@mhdawson mhdawson mentioned this issue Dec 5, 2016
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Dec 7, 2016

Giving it a quick look, moving to sequential will probably make it more reliable. /cc @nodejs/testing

@Trott
Copy link
Member

Trott commented Apr 27, 2017

Failed again today. https://ci.nodejs.org/job/node-test-commit-freebsd/8596/nodes=freebsd10-64/console

not ok 664 parallel/test-https-set-timeout-server
  ---
  duration_ms: 1.263
  severity: fail
  stack: |-
    # serverTimeout
    # serverRequestTimeout
    # serverResponseTimeout
    # serverRequestNotTimeoutAfterEnd
    # serverResponseTimeoutWithPipeline
    # idleTimeout
    ok
    Mismatched <anonymous> function calls. Expected 1, actual 0.
        at idleTimeout (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-https-set-timeout-server.js:170:44)
        at run (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-https-set-timeout-server.js:52:5)
        at Server.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-https-set-timeout-server.js:152:5)
        at emitOne (events.js:115:13)
        at Server.emit (events.js:210:7)
        at TLSSocket.socketOnTimeout (_http_server.js:385:35)
        at emitNone (events.js:105:13)
        at TLSSocket.emit (events.js:207:7)
        at TLSSocket.Socket._onTimeout (net.js:374:8)

@Trott
Copy link
Member

Trott commented Apr 27, 2017

I'm going to run some stress tests on it in parallel vs. sequential and see what happens.

@Trott
Copy link
Member

Trott commented Apr 27, 2017

CI stress test on freebsd10-64 with -j 4 --repeat=4:

https://ci.nodejs.org/job/node-stress-single-test/1175/nodes=freebsd10-64/console

@Trott
Copy link
Member

Trott commented Apr 27, 2017

Ci stress test on freebsd10-64 with -j 8 --repeat=8:

https://ci.nodejs.org/job/node-stress-single-test/1176/nodes=freebsd10-64/console

@Trott
Copy link
Member

Trott commented Apr 27, 2017

8 seems to be enough to cause failures identical to what we're seeing in CI from time to time, so that's good. But the errors are infrequent. (I got 1 in 500 runs.) Trying 16 to see if we can get failures to happen with greater frequency:

https://ci.nodejs.org/job/node-stress-single-test/1177/nodes=freebsd10-64/console

That gives me 92 failures out of 100 runs. Cool. Solution is certainly to move it to sequential but I'll run a stress test on that anyway.

@Trott
Copy link
Member

Trott commented Apr 27, 2017

Actually, I wonder if moving the setting of the server timeout to the callback might be the solution...

Trott added a commit to Trott/io.js that referenced this issue Apr 27, 2017
@Trott
test: move test to sequential for reliability
75e284d 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

Fixes: nodejs#10130
@Trott Trott mentioned this issue Apr 27, 2017
Closed
2 tasks
@Trott Trott closed this as completed in 0833d31 Apr 30, 2017
evanlucas pushed a commit that referenced this issue May 1, 2017
@Trott @evanlucas
test: move test to sequential for reliability
864cec7 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas pushed a commit that referenced this issue May 2, 2017
@Trott @evanlucas
test: move test to sequential for reliability
c75d723 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas pushed a commit that referenced this issue May 2, 2017
@Trott @evanlucas
test: move test to sequential for reliability
141c347 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
evanlucas pushed a commit that referenced this issue May 3, 2017
@Trott @evanlucas
test: move test to sequential for reliability
592db37 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn pushed a commit that referenced this issue May 15, 2017
@Trott @gibfahn
test: move test to sequential for reliability
c1e4b2f 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: #12704
Fixes: #10130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
@Trott @andrew749
test: move test to sequential for reliability
873451b 
test-https-set-timeout-server fails under load. Move it to sequential so
it is not competing with other tests.

PR-URL: nodejs/node#12704
Fixes: nodejs/node#10130
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
freebsd Issues and PRs related to the FreeBSD platform. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: move test to sequential for reliability Trott/io.js
3 participants
@mscdex @Trott @mhdawson