Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url-whatwg: disallow invalid IPv4 in IPv6 parser #10655

Closed
targos opened this issue Jan 6, 2017 · 3 comments
Closed

url-whatwg: disallow invalid IPv4 in IPv6 parser #10655

targos opened this issue Jan 6, 2017 · 3 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@targos
Copy link
Member

targos commented Jan 6, 2017

Refs: whatwg/url#196 and whatwg/url#195

@nodejs/url
@targos targos added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 6, 2017
@jasnell
Copy link
Member

jasnell commented Jan 6, 2017

Just noting: this issue is about the parser accepting invalid IPv4-in-IPv6 inputs. A spec fix is being proposed that will need to be implemented here.

@domenic
Copy link
Contributor

domenic commented Jan 12, 2017 •
edited
Loading

This has landed in the spec, along with tests at web-platform-tests/wpt#4513.

In a related area, someone found a separate bug in jsdom/whatwg-url's IPv6 parser, and we added a WPT for it: web-platform-tests/wpt#4528. Maybe pull that in while you're here.

@TimothyGu TimothyGu changed the title url: track whatwg pr #196 url-whatwg: disallow invalid IPv4 in IPv6 parser Jan 22, 2017
@joyeecheung joyeecheung mentioned this issue Jan 31, 2017
Closed
3 tasks
@watilde
Copy link
Member

watilde commented Apr 10, 2017

I'm working on this.

@watilde watilde mentioned this issue Apr 10, 2017
Closed
2 tasks
watilde added a commit to watilde/node that referenced this issue Apr 12, 2017
@watilde
url: disallow invalid IPv4 in IPv6 parser
a5786ac 
Fixes: nodejs#10655
TimothyGu pushed a commit to TimothyGu/node that referenced this issue Apr 25, 2017
@watilde @TimothyGu
url: disallow invalid IPv4 in IPv6 parser
f484cfd 
PR-URL: nodejs#12507
Fixes: nodejs#10655
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue May 1, 2017
@watilde @evanlucas
url: disallow invalid IPv4 in IPv6 parser
29531d2 
PR-URL: #12507
Fixes: #10655
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jasnell @domenic @watilde @targos