We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi. Today I tried to run something similar to this:
var data = true; fs.write(fd, data, cb);
data value must be coerced to string as mentioned in API. But that failed with message:
Assertion failed: val->IsString() == true, file src\string_bytes.cc, line 286
fs.writeSync, however worked well.
Then I found this: https://github.com/iReal/io.js/blob/v1.x/lib/fs.js#L632-L633
There should be !==, not ===.
The text was updated successfully, but these errors were encountered:
fs: fix .write() not coercing non-string values
6d2a421
fix: nodejs#1098
cf565b5
Fixes: #1098 PR-URL: #1102 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
@iReal thanks to @Fishrock123 this should now be fixed on HEAD. If this issue comes back up, please reopen the issue. Thanks for reporting this!
HEAD
Sorry, something went wrong.
No branches or pull requests
Hi. Today I tried to run something similar to this:
data value must be coerced to string as mentioned in API.
But that failed with message:
fs.writeSync, however worked well.
Then I found this:
https://github.com/iReal/io.js/blob/v1.x/lib/fs.js#L632-L633
There should be !==, not ===.
The text was updated successfully, but these errors were encountered: