Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V6.x crash with illegal spread as single arrow parameter #12017

Closed
targos opened this issue Mar 24, 2017 · 1 comment
Closed

V6.x crash with illegal spread as single arrow parameter #12017

targos opened this issue Mar 24, 2017 · 1 comment
Labels
confirmed-bug Issues with confirmed bugs. v8 engine Issues and PRs related to the V8 dependency.

Comments

@targos
Copy link
Member

targos commented Mar 24, 2017

  • Version: 6.10.1
  • Platform: Linux
  • Subsystem: V8

Repro: node -e "(...[42]) => 42"

Fix: v8/v8@b9f682b
I found this while investigating #11977
@targos targos added confirmed-bug Issues with confirmed bugs. v8 engine Issues and PRs related to the V8 dependency. labels Mar 24, 2017
targos added a commit to targos/node that referenced this issue Mar 25, 2017
@targos
deps: cherry-pick b9f682b from upstream V8
7a38c51 
Original commit message:

    Fix bug with illegal spread as single arrow parameter

    R=adamk@chromium.org
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{nodejs#37196}

Fixes: nodejs#12017
MylesBorins pushed a commit that referenced this issue Mar 28, 2017
@targos @MylesBorins
deps: cherry-pick b9f682b from upstream V8
ba105fd 
Original commit message:

    Fix bug with illegal spread as single arrow parameter

    R=adamk@chromium.org
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{#37196}

Fixes: #12017

PR-URL: #12037
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this issue Mar 28, 2017
Closed
MylesBorins pushed a commit that referenced this issue Mar 29, 2017
@targos @MylesBorins
deps: cherry-pick b9f682b from upstream V8
78e27f4 
Original commit message:

    Fix bug with illegal spread as single arrow parameter

    R=adamk@chromium.org
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{#37196}

Fixes: #12017

PR-URL: #12037
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 29, 2017
@targos @MylesBorins
deps: cherry-pick b9f682b from upstream V8
8dfc710 
Original commit message:

    Fix bug with illegal spread as single arrow parameter

    R=adamk@chromium.org
    BUG=chromium:621496
    LOG=N

    Review-Url: https://codereview.chromium.org/2084703005
    Cr-Commit-Position: refs/heads/master@{#37196}

Fixes: #12017

PR-URL: #12037
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targos
Copy link
Member Author

targos commented Apr 7, 2017

Fixed in 8dfc710

@targos targos closed this as completed Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@targos