setTimeout(function(){throw null},0) crashes toplevel

[DemiMarie]

• Version: v6.10.0
• Platform: Linux localhost.hsd1.tn.comcast.net 4.10.8-200.fc25.x86_64 #1 SMP Fri Mar 31 13:20:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: timer

If I run

setTimeout(function() { throw null }, 0)

the REPL crashes with

TypeError: Cannot read property 'stack' of null
    at Domain.<anonymous> (repl.js:392:17)
    at emitOne (events.js:96:13)
    at Domain.emit (events.js:188:7)
    at Domain._errorHandler (domain.js:97:23)
    at process._fatalException (bootstrap_node.js:293:33)

Obviously such code is buggy (and would normally cause a crash). However, I don’t think that it should crash the toplevel, hence this report.

[vsemozhetbyt]

Can reproduce on Windows with 8.0.0rc:

> repl.js:291
    } else if (e.stack && self.replMode === exports.REPL_MODE_STRICT) {
                ^

TypeError: Cannot read property 'stack' of null
    at Domain.debugDomainError (repl.js:291:17)
    at emitOne (events.js:115:13)
    at Domain.emit (events.js:210:7)
    at Domain._errorHandler (domain.js:118:23)
    at process._fatalException (bootstrap_node.js:311:33)

[refack]

repro on Windows with v4 v6, v7, v8, Ubuntu v7

[Fishrock123]

Looks like a domain thing? I'm removing good first contrib because I feel like this won't be particularly clear.

[refack]

Looks like a domain thing? I'm removing good first contrib because I feel like this won't be particularly clear

IMHO just needs an e && as in

  repl.js:291
    } else if (e && e.stack && self.replMode === exports.REPL_MODE_STRICT) {

[XadillaX]

I think this issue should be closed?

[bnoordhuis]

I don't think this was actually fixed, #12400 wasn't merged.

[benjamingr]

Seeing as this is unhandled - I'll take a shot.