-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark, http, test: test/sequential/test-benchmark-http.js is incomplete #12903
Comments
vsemozhetbyt
added
benchmark
Issues and PRs related to the benchmark subsystem.
http
Issues or PRs related to the http subsystem.
test
Issues and PRs related to the tests.
labels
May 8, 2017
cc @joyeecheung |
1 task
joyeecheung
added a commit
to joyeecheung/node
that referenced
this issue
May 9, 2017
Previously when there is an error in the chunky client of the http benchmark, the server would not check the exit code and thus produce invalid results. Fixes: nodejs#12903
3 tasks
anchnk
pushed a commit
to anchnk/node
that referenced
this issue
May 19, 2017
PR-URL: nodejs#12904 Refs: nodejs#12903 Refs: nodejs@ff001c1 Reviewed-By: Anna Henningsen <anna@addaleax.net>
anchnk
pushed a commit
to anchnk/node
that referenced
this issue
May 19, 2017
Previously when there is an error in the chunky client of the http benchmark, the server would not check the exit code and thus produce invalid results. PR-URL: nodejs#12916 Fixes: nodejs#12903 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
benchmark/http/_chunky_http_client.js
is used as a forked child by thebenchmark/http/http_server_for_chunky_client.js
).This child file contained an error: the path still not fixed after the ff001c1 (fixed in #12904).
This child threw preventing the benchmark from completion, but this did not cause test/sequential/test-benchmark-http.js to fail:
The text was updated successfully, but these errors were encountered: