Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark, http, test: test/sequential/test-benchmark-http.js is incomplete #12903

Closed
vsemozhetbyt opened this issue May 8, 2017 · 1 comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Comments

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented May 8, 2017

  • Version: 8.0.0 nightly 2017 05 07
  • Platform: Windows 7 x64
  • Subsystem: benchmark, http, test

benchmark/http/_chunky_http_client.js is used as a forked child by the benchmark/http/http_server_for_chunky_client.js).

This child file contained an error: the path still not fixed after the ff001c1 (fixed in #12904).

This child threw preventing the benchmark from completion, but this did not cause test/sequential/test-benchmark-http.js to fail:

<...>
http\end-vs-write-end.js
http\end-vs-write-end.js method="write" c=1 len=1 type="asc" benchmarker="test-double": 1
http\end-vs-write-end.js method="end" c=1 len=1 type="asc" benchmarker="test-double": 1
http\end-vs-write-end.js method="write" c=1 len=1 type="utf" benchmarker="test-double": 1
http\end-vs-write-end.js method="end" c=1 len=1 type="utf" benchmarker="test-double": 1
http\end-vs-write-end.js method="write" c=1 len=1 type="buf" benchmarker="test-double": 1
http\end-vs-write-end.js method="end" c=1 len=1 type="buf" benchmarker="test-double": 1

http\http_server_for_chunky_client.js
module.js:487
    throw err;
    ^

Error: Cannot find module '../../test/common.js'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (j:\temp\_git\node-fork\benchmark\http\_chunky_http_client.js:6:12)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)

http\simple.js
http\simple.js res="normal" c=1 chunks=0 len=1 type="bytes" benchmarker="test-double": 1
<...>
@vsemozhetbyt vsemozhetbyt added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels May 8, 2017
@vsemozhetbyt
Copy link
Contributor Author

cc @joyeecheung

vsemozhetbyt added a commit that referenced this issue May 8, 2017
PR-URL: #12904
Refs: #12903
Refs: ff001c1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit to joyeecheung/node that referenced this issue May 9, 2017
Previously when there is an error in the chunky client of the
http benchmark, the server would not check the exit code and
thus produce invalid results.

Fixes: nodejs#12903
anchnk pushed a commit to anchnk/node that referenced this issue May 19, 2017
PR-URL: nodejs#12904
Refs: nodejs#12903
Refs: nodejs@ff001c1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
anchnk pushed a commit to anchnk/node that referenced this issue May 19, 2017
Previously when there is an error in the chunky client of the
http benchmark, the server would not check the exit code and
thus produce invalid results.

PR-URL: nodejs#12916
Fixes: nodejs#12903
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this issue Jun 20, 2017
PR-URL: #12904
Refs: #12903
Refs: ff001c1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this issue Jul 11, 2017
PR-URL: #12904
Refs: #12903
Refs: ff001c1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant