Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for fs.watch needs to say that filename is also available for macOS #13108

Closed
aashil opened this issue May 18, 2017 · 0 comments
Closed

Documentation for fs.watch needs to say that filename is also available for macOS #13108

aashil opened this issue May 18, 2017 · 0 comments
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Comments

@aashil
Copy link
Contributor

aashil commented May 18, 2017

Quoting the documentation for fs.watch from https://nodejs.org/api/fs.html#fs_filename_argument

Providing filename argument in the callback is only supported on Linux and Windows.

Filename is also available on macOS - we could update the documentation to reflect this.
@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label May 18, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label May 18, 2017
chris--young pushed a commit to chris--young/node that referenced this issue May 19, 2017
docs: list macOS as supporting filename argument
a7ba706 
Fixes: nodejs#13108
@chris--young chris--young mentioned this issue May 19, 2017
Closed
3 tasks
chris--young pushed a commit to chris--young/node that referenced this issue May 21, 2017
doc: list macOS as supporting filename argument
5fee2e8 
Fixes: nodejs#13108
chris--young pushed a commit to chris--young/node that referenced this issue May 21, 2017
test: check fs.watch filename on Linux and macOS
9bd4012 
Fixes: nodejs#13108
chris--young pushed a commit to chris--young/node that referenced this issue May 22, 2017
test: fs.watch filename check for Windows & AIX
64884c2 
Fixes: nodejs#13108
@refack refack closed this as completed in c470f04 May 22, 2017
jasnell pushed a commit that referenced this issue May 23, 2017
@jasnell
doc: list macOS as supporting filename argument
f47c6f7 
also added regression tests

PR-URL: #13111
Fixes: #13108
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
jasnell pushed a commit that referenced this issue May 23, 2017
@jasnell
doc: list macOS as supporting filename argument
1aa68f9 
also added regression tests

PR-URL: #13111
Fixes: #13108
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: list macOS as supporting filename argument chris--young/node
3 participants
@mscdex @Fishrock123 @aashil