Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: incorrect backtick usage #13382

Closed
mscdex opened this issue Jun 2, 2017 · 0 comments
Closed

doc: incorrect backtick usage #13382

mscdex opened this issue Jun 2, 2017 · 0 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. tls Issues and PRs related to the tls subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jun 2, 2017 •
edited
Loading

  • Version: master, v8.x
  • Platform: n/a
  • Subsystem: doc

https://nodejs.org/docs/latest/api/tls.html#tls_tls_connect_options_callback and https://nodejs.org/docs/v8.0.0/api/tls.html#tls_tls_createserver_options_secureconnectionlistener have some formatting issues in their descriptions for NPNProtocols. It looks like some incorrectly placed backticks.
@mscdex mscdex added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. tls Issues and PRs related to the tls subsystem. labels Jun 2, 2017
pbininda added a commit to pbininda/node that referenced this issue Jun 2, 2017
@pbininda
doc: add missing backticks to doc/api/tls.md
55d7789 
Fixes: nodejs#13382
@pbininda pbininda mentioned this issue Jun 2, 2017
Closed
2 tasks
@refack refack closed this as completed in 7637347 Jun 4, 2017
jasnell pushed a commit that referenced this issue Jun 5, 2017
@pbininda @jasnell
doc: add missing backticks to doc/api/tls.md
6c56bbd 
PR-URL: #13394
Fixes: #13382
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add missing backticks to doc/api/tls.md pbininda/node
1 participant
@mscdex