-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
known limitation: when running with --inspect=localhost:0
only one port is printed
#13772
Comments
My understanding is that the console output (e.g. the "Debugger listening on ws://localhost:63448/38595be5-d6d8-4142-bdbb-25133971f734") message is pretty much considered an API as other software may be parsing the output. I can change the output to include multiple ports/hosts - but I would like to discuss the suggested format. |
I don't think the output format should be changed, the message should just be repeated in a loop, once for each listen that was done in |
And to be clear, I don't think thats semver-major. Any code grepping output will find one of the instances, first or last, who knows (but its random right now which of the server socket addresses is printed anyway). |
@refack What would you like to do with this? I suggest either close as a known limitation or promote to a feature request (print multiple lines). |
I'm relabeling this feature request, it seems useful. |
Some hostnames have multiple interfaces. Before this commit, the inspector only printed the first one. Now, it prints them all. No test. I can't think of a reliable way to test this on the CI matrix. Fixes: nodejs#13772
Some hostnames have multiple interfaces. Before this commit, the inspector only printed the first one. Now, it prints them all. No test. I can't think of a reliable way to test this on the CI matrix. PR-URL: #26008 Fixes: #13772 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Some hostnames have multiple interfaces. Before this commit, the inspector only printed the first one. Now, it prints them all. No test. I can't think of a reliable way to test this on the CI matrix. PR-URL: #26008 Fixes: #13772 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Some hostnames have multiple interfaces. Before this commit, the inspector only printed the first one. Now, it prints them all. No test. I can't think of a reliable way to test this on the CI matrix. PR-URL: #26008 Fixes: #13772 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com>
A know limitation after #13478
If node is started with a
hostname
and port 0, the process will possibly bind 2 sockets with two different ports, but print only oneThe text was updated successfully, but these errors were encountered: