Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate failing test-fs-readdir-ucs2 on Raspberry Pi #14028

Closed
Trott opened this issue Jul 1, 2017 · 4 comments
Closed

investigate failing test-fs-readdir-ucs2 on Raspberry Pi #14028

Trott opened this issue Jul 1, 2017 · 4 comments
Labels
build Issues and PRs related to build files or the CI. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Jul 1, 2017

  • Version: master
  • Platform: Raspberry PI
  • Subsystem: test

From nodejs/build#774:

parallel/test-fs-readdir-ucs2 is failing on all of the Pi's: Error: EINVAL: invalid argument, open '/home/iojs/build/workspace/node-test-binary-arm/test/tmp.0/=���', this is likely to be to do with it being on an NFS share exported from a ZFS volume. I'm going to have to defer to @nodejs/testing to figure out how to handle that special case. Let me know if there's something I should be doing for that mount to enable UCS2 (no promises that it's achievable on my end tho).
@Trott Trott added build Issues and PRs related to build files or the CI. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels Jul 1, 2017
@Trott Trott mentioned this issue Jul 1, 2017
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Jul 1, 2017

Fix in #14029

Trott added a commit to Trott/io.js that referenced this issue Jul 3, 2017
@Trott
test: skip test-fs-readdir-ucs2 if no support
f03541e 
If the filesystem does not support UCS2, do not run the test.

Fixes: nodejs#14028
@refack refack closed this as completed in 4dd7d09 Jul 4, 2017
@refack
Copy link
Contributor

refack commented Jul 4, 2017

Two follow up issues:

  1. the UCS2 string break TAP parsing https://ci.nodejs.org/job/node-test-binary-arm/9039/RUN_SUBSET=6,label=pi1-raspbian-wheezy/tapResults/
  2. test throws ENOENT in WSL (when using shared NTFS mounts):
$ NVM_NODEJS_ORG_MIRROR=https://nodejs.org/download/nightly Now using node v9.0.0-nightly20170703fe730d34ce (npm v5.0.3)

$ node test/parallel/test-fs-readdir-ucs2.js
/mnt/d/code/node-cur/test/parallel/test-fs-readdir-ucs2.js:22
  throw e;
  ^

Error: ENOENT: no such file or directory, open '/mnt/d/code/node-cur/test/tmp/=�♦�'
    at Object.fs.openSync (fs.js:651:18)
    at Object.<anonymous> (/mnt/d/code/node-cur/test/parallel/test-fs-readdir-ucs2.js:18:19)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Function.Module.runMain (module.js:605:10)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:575:3

and assertion fails on native WSL volume:

refael@refaelux:~/node$ node test/parallel/test-fs-readdir-ucs2.js
assert.js:55
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: <Buffer 3d d8 04 dc> deepStrictEqual <Buffer 3d ef bf bd 04 ef bf bd>
    at fs.readdir.common.mustCall (/home/refael/node/test/parallel/test-fs-readdir-ucs2.js:29:10)
    at /home/refael/node/test/common/index.js:518:15
    at FSReqWrap.oncomplete (fs.js:135:15)

@refack refack reopened this Jul 4, 2017
addaleax pushed a commit that referenced this issue Jul 11, 2017
@Trott @addaleax
test: skip test-fs-readdir-ucs2 if no support
5f45165 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this issue Jul 18, 2017
@Trott @addaleax
test: skip test-fs-readdir-ucs2 if no support
d288cf1 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Fishrock123 pushed a commit that referenced this issue Jul 19, 2017
@Trott @Fishrock123
test: skip test-fs-readdir-ucs2 if no support
e583e3b 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this issue Aug 15, 2017
@Trott @MylesBorins
test: skip test-fs-readdir-ucs2 if no support
c57a786 
If the filesystem does not support UCS2, do not run the test.

PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Trott added a commit to Trott/io.js that referenced this issue Aug 15, 2017
@Trott
test: skip test-fs-readdir-ucs2 if no support
f41047e 
If the filesystem does not support UCS2, do not run the test.

PR-URL: nodejs#14029
Fixes: nodejs#14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this issue Aug 16, 2017
@Trott @MylesBorins
test: skip test-fs-readdir-ucs2 if no support
175d46e 
If the filesystem does not support UCS2, do not run the test.

Backport-PR-URL: #14835
PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this issue Sep 5, 2017
@Trott @MylesBorins
test: skip test-fs-readdir-ucs2 if no support
46e4a02 
If the filesystem does not support UCS2, do not run the test.

Backport-PR-URL: #14835
PR-URL: #14029
Fixes: #14028
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeAR
Copy link
Member

Ping @nodejs/testing we should probably investigate this again and run a stress test.

It would be great to get a green CI before the next Code & Learn.

@apapirovski
Copy link
Member

As far as I can tell this has been resolved? Feel free to re-open if I'm reading that incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: skip test-fs-readdir-ucs2 if no support Trott/io.js
4 participants
@apapirovski @refack @Trott @BridgeAR