Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: investigate test-http-server-keep-alive-timeout-slow-client-headers #14033

Closed
refack opened this issue Jul 1, 2017 · 6 comments
Closed

test: investigate test-http-server-keep-alive-timeout-slow-client-headers #14033

refack opened this issue Jul 1, 2017 · 6 comments
Assignees
@aqrln
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. http Issues or PRs related to the http subsystem.

Comments

@refack
Copy link
Contributor

refack commented Jul 1, 2017

  • Version: master
  • Platform: freeBSD
  • Subsystem: test
678	parallel/test-http-server-keep-alive-timeout-slow-client-headers	
duration_ms	1.131
severity	fail
stack	
events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: write after end
    at writeAfterEnd (_stream_writable.js:220:12)
    at Socket.Writable.write (_stream_writable.js:271:5)
    at Socket.write (net.js:699:40)
    at request (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-http-server-keep-alive-timeout-slow-client-headers.js:36:12)
    at common.mustCall (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-http-server-keep-alive-timeout-slow-client-headers.js:20:7)
    at /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common/index.js:520:15
    at onHeaders (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-http-server-keep-alive-timeout-slow-client-headers.js:54:7)
    at Socket.onData (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-http-server-keep-alive-timeout-slow-client-headers.js:47:9)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)

https://ci.nodejs.org/job/node-test-commit-freebsd/10068/nodes=freebsd10-64/tapResults/
@refack refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. http Issues or PRs related to the http subsystem. labels Jul 1, 2017
@refack
Copy link
Contributor Author

refack commented Jul 1, 2017

/cc @aqrln

@Trott
Copy link
Member

Trott commented Jul 2, 2017

I'm able to replicate this under load (as well as another error) with this:

tools/test.py --repeat 368 -j 92 parallel/test-http-server-keep-alive-timeout-slow-client-headers

As usual, the suspected culprit (without looking at the code) is a race condition....

@aqrln
Copy link
Contributor

aqrln commented Jul 2, 2017

@refack thanks for the ping. I am currently at a conference and then I'm having/continuing a little vacation for the next few days, so I'm not able to look into it right now, sorry. I will take a look after Wednesday if no one beats me to it.

@refack
Copy link
Contributor Author

refack commented Jul 2, 2017

@refack thanks for the ping. I am currently at a conference and then I'm having/continuing a little vacation for the next few days, so I'm not able to look into it right now, sorry. I will take a look after Wednesday if no one beats me to it.

@aqrln Have fun!

@refack refack mentioned this issue Jul 3, 2017
Closed
2 tasks
@aqrln aqrln self-assigned this Jul 7, 2017
@refack
Copy link
Contributor Author

refack commented Jul 18, 2017

@aqrln ping
https://ci.nodejs.org/job/node-test-commit-freebsd/10428/nodes=freebsd10-64

not ok 690 parallel/test-http-server-keep-alive-timeout-slow-server
  ---
  duration_ms: 1.608
  severity: fail
  stack: |-
    events.js:182
          throw er; // Unhandled 'error' event
          ^
    
    Error: socket hang up
        at createHangUpError (_http_client.js:345:15)
        at Socket.socketOnEnd (_http_client.js:437:23)
        at emitNone (events.js:110:20)
        at Socket.emit (events.js:207:7)
        at endReadableNT (_stream_readable.js:1045:12)
        at _combinedTickCallback (internal/process/next_tick.js:138:11)
        at process._tickCallback (internal/process/next_tick.js:180:9)
  ...

@aqrln
Copy link
Contributor

aqrln commented Jul 19, 2017

@refack oops, sorry, I forgot about it. Will look into it in a few hours, it's time to return to GitHub after some period of inactivity, I guess :D

aqrln added a commit to aqrln/node that referenced this issue Jul 19, 2017
@aqrln
test: move timing-dependent tests to sequential
c87fb3b 
Move test-http-server-keep-alive-timeout-slow-server and
test-http-server-keep-alive-timeout-slow-client-headers from parallel to
sequential to (hopefully) resolve test flakiness on freebsd10-64.

Refs: nodejs#14033
Refs: nodejs#9317
@aqrln aqrln mentioned this issue Jul 19, 2017
Closed
2 tasks
@aqrln aqrln closed this as completed in 239ebf0 Jul 22, 2017
addaleax pushed a commit that referenced this issue Jul 22, 2017
@aqrln @addaleax
test: move timing-dependent tests to sequential
9e9ce23 
Move test-http-server-keep-alive-timeout-slow-server and
test-http-server-keep-alive-timeout-slow-client-headers from parallel to
sequential to resolve test flakiness on freebsd10-64.

Fixes: #14033
Refs: #9317
PR-URL: #14377
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fishrock123 pushed a commit that referenced this issue Jul 24, 2017
@aqrln @Fishrock123
test: move timing-dependent tests to sequential
953736c 
Move test-http-server-keep-alive-timeout-slow-server and
test-http-server-keep-alive-timeout-slow-client-headers from parallel to
sequential to resolve test flakiness on freebsd10-64.

Fixes: #14033
Refs: #9317
PR-URL: #14377
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aqrln aqrln

Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. freebsd Issues and PRs related to the FreeBSD platform. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@refack @Trott @aqrln