test: new flakiness in test-process-kill-null.js #14141
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
process
Issues and PRs related to the process subsystem.
regression
Issues related to regressions.
test
Issues and PRs related to the tests.
windows
Issues and PRs related to the Windows platform.
Comments
refack
added
flaky-test
|
When in doubt, I'd say revert & reopen PR. I imagine if you were confident that you could fix it quickly (or determined to do so), then that's what you'd do and you wouldn't ask. :-D And I'd reserve "mark as flaky" for situations where we do not know how to fix the test. If reverting fixes the flakiness, I'd say that's preferable. green > yellow |
|
Oh, I guess another factor is just how flaky. Like, if it's one in a thousand runs, leaving it open while there's an active effort to fix it over a few days is A-OK to me. If it's one in 10, OMG no, revert. |
|
I guess it's more in the 1 in 10 range so #14142. |
refack
added a commit
to refack/node
that referenced
this issue
Jul 9, 2017
This reverts commit 44483b6. PR-URL: nodejs#14142 Fixes: nodejs#14141 Refs: nodejs#14099 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
master44483b6 introduced flakiness to
test/parallel/test-process-kill-null.js.Looking for advice on the best course of action:
/cc @nodejs/testing @nodejs/platform-windows
The text was updated successfully, but these errors were encountered: