-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: flaky test-net-can-reset-timeout
#14241
Comments
Unsurprisingly, this is an issue with parallelism and is not specific to FreeBSD. It is probably just showing up on FreeBSD because that is one of our more parallelized hosts for tests in CI. It's also likely surfaced due to the start-up performance hit of turning off V8 snapshots; even though this test doesn't use Here is partial output of a reproduction on macOS: $ tools/test.py -j 92 --repeat 920 test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
at emitOne (events.js:115:13)
at Server.emit (events.js:210:7)
at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
at emitOne (events.js:115:13)
at Server.emit (events.js:210:7)
at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
at emitOne (events.js:115:13)
at Server.emit (events.js:210:7)
at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
at emitOne (events.js:115:13)
at Server.emit (events.js:210:7)
at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
at emitOne (events.js:115:13)
at Server.emit (events.js:210:7)
at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
at emitOne (events.js:115:13)
at Server.emit (events.js:210:7)
at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js
=== release test-net-can-reset-timeout ===
Path: parallel/test-net-can-reset-timeout
timeout
timeout
server side end
client side end
Mismatched <anonymous> function calls. Expected exactly 1, actual 2.
at Object.exports.mustCall (/Users/rtrott/io.js/test/common/index.js:480:10)
at Server.<anonymous> (/Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js:31:31)
at Server.<anonymous> (/Users/rtrott/io.js/test/common/index.js:512:15)
at emitOne (events.js:115:13)
at Server.emit (events.js:210:7)
at TCP.onconnection (net.js:1553:8)
Command: out/Release/node /Users/rtrott/io.js/test/parallel/test-net-can-reset-timeout.js |
Problem occurs if the timeout fires more than once which can happen on a heavily loaded host. The test ought to permit |
Fix coming in a few minutes. |
Fix is in #14257. |
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
master
https://ci.nodejs.org/job/node-test-commit-freebsd/10321/nodes=freebsd10-64/
The test:
/cc @nodejs/testing @nodejs/platform-freebsd @nodejs/streams
P.S. to whomever tackles this, could you add a comment explaining what this is testing a la doc/guides/writing-tests.md
The text was updated successfully, but these errors were encountered: