Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--inspector-brk does not stop in code passed with the -e flag #14577

Closed
eugeneo opened this issue Aug 1, 2017 · 2 comments · Fixed by #14581
Closed

--inspector-brk does not stop in code passed with the -e flag #14577

eugeneo opened this issue Aug 1, 2017 · 2 comments · Fixed by #14581
Assignees
@eugeneo
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@eugeneo
Copy link
Contributor

eugeneo commented Aug 1, 2017

Running node like "node --inspect-brk -e "console.log('Hello')" does not break before executing the JavaScript code.
@eugeneo eugeneo self-assigned this Aug 1, 2017
@eugeneo eugeneo added the inspector Issues and PRs related to the V8 inspector protocol label Aug 1, 2017
@refack
Copy link
Contributor

refack commented Aug 1, 2017

It acts really strange, AFAICT it does wait for the debugger to attach, but then the debugger does not break.

@eugeneo
Copy link
Contributor Author

eugeneo commented Aug 1, 2017

It is by design - old debugger did a same. I have one ugly fix, I'll create a PR and we can discuss.

@eugeneo eugeneo mentioned this issue Aug 1, 2017
Merged
3 tasks
jasnell pushed a commit that referenced this issue Sep 20, 2017
@jasnell
inspector: break in eval script
25692a9 
Fixes: #14577
PR-URL: #14581
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
inspector: break in eval script
ec44d2c 
Fixes: nodejs/node#14577
PR-URL: nodejs/node#14581
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
inspector: break in eval script
0d206fd 
Fixes: nodejs/node#14577
PR-URL: nodejs/node#14581
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugeneo eugeneo

Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

inspector: break in eval script
2 participants
@refack @eugeneo