-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/parallel/test-async-wrap-getasyncid.js crashing #14599
Comments
/cc @nodejs/async_hooks |
@matthewloring I'm assuming this is intermittent, right? |
I'm not sure the best way to capture a stack at the point where the leaked object is allocated/freed. As best I can tell the allocation happens with this stack:
and the free happens with this stack:
But these aren't consistent with the stacks reported by asan. |
I'm marking as |
This fixes a bug introduced in 727b291 where code managing the `uv_timer_t` for a `ChannelWrap` instance was left unchanged, when it should have changed the lifetime of the handle to being tied to the `ChannelWrap` instance’s lifetime. Fixes: nodejs#14599 Ref: nodejs#14518
Fix is in #14634, this really is my bad. |
Now failing in FIPS mode! :-D https://ci.nodejs.org/job/node-test-commit-linux-fips/10108/nodes=ubuntu1404-64/console not ok 78 parallel/test-async-wrap-getasyncid
---
duration_ms: 0.620
severity: crashed
stack: |-
oh no!
exit code: CRASHED (Signal: 11) |
@Trott The fix hasn't landed yet. Hopefully it will address things on FIPS as well. |
This fixes a bug introduced in 727b291 where code managing the `uv_timer_t` for a `ChannelWrap` instance was left unchanged, when it should have changed the lifetime of the handle to being tied to the `ChannelWrap` instance’s lifetime. Fixes: #14599 Ref: #14518 PR-URL: #14634 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Example asan output
The text was updated successfully, but these errors were encountered: