Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky parallel/test-benchmark-buffer.js on SmartOS #15372

Closed
mscdex opened this issue Sep 12, 2017 · 6 comments
Closed

Investigate flaky parallel/test-benchmark-buffer.js on SmartOS #15372

mscdex opened this issue Sep 12, 2017 · 6 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@mscdex
Copy link
Contributor

mscdex commented Sep 12, 2017

  • Version: master
  • Platform: smartos
  • Subsystem: test

Just saw this test fail due to timeout on smartos15-64.
@mscdex mscdex added benchmark Issues and PRs related to the benchmark subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests. labels Sep 12, 2017
@Trott
Copy link
Member

Trott commented Sep 12, 2017

Because Jenkins jobs get cleaned out after a few days, here's what the failure looks like:

not ok 112 parallel/test-benchmark-buffer
  ---
  duration_ms: 120.620
  severity: fail
  stack: |-
    timeout

@Trott
Copy link
Member

Trott commented Sep 12, 2017

Taking a look at this, I don't think there's much to be done aside from moving the test to sequential.

Trott added a commit to Trott/io.js that referenced this issue Sep 12, 2017
@Trott
test: move test-benchmark-buffer to sequential
5d698bc 
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.

Fixes: nodejs#15372
@Trott Trott mentioned this issue Sep 12, 2017
Closed
2 tasks
@Trott
Copy link
Member

Trott commented Sep 12, 2017

#15373

@mscdex
Copy link
Contributor Author

mscdex commented Sep 12, 2017 •
edited
Loading

Stress test to see if it's not a problem with the test itself: https://ci.nodejs.org/job/node-stress-single-test/1409/

@Trott
Copy link
Member

Trott commented Sep 12, 2017

Stress test to see if it's not a problem with the test itself: https://ci.nodejs.org/job/node-stress-single-test/1409/

For clarity: If that stress test comes back green, that would suggest that moving the test to sequential is a solution (or at least an effective workaround).

If that stress test comes back red, that would suggest that moving the test to sequential would not eliminate the test flakiness (although it would likely reduce test flakiness).

@refack
Copy link
Contributor

refack commented Sep 13, 2017

https://ci.nodejs.org/job/node-stress-single-test/1409/ has been running for 19h (OK: 1934 NOT OK: 0), so I stoped it.
Test seems to be stable when run alone.

addaleax pushed a commit to addaleax/ayo that referenced this issue Sep 17, 2017
@Trott @addaleax
test: move test-benchmark-buffer to sequential
d2722fb 
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.

PR-URL: nodejs/node#15373
Fixes: nodejs/node#15372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this issue Sep 20, 2017
@Trott @jasnell
test: move test-benchmark-buffer to sequential
4d26c68 
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.

PR-URL: #15373
Fixes: #15372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
@Trott
test: move test-benchmark-buffer to sequential
9f8e9b1 
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.

PR-URL: nodejs/node#15373
Fixes: nodejs/node#15372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: move test-benchmark-buffer to sequential Trott/io.js
3 participants
@mscdex @refack @Trott