Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--link-module Windows support? #15377

Closed
anmonteiro opened this issue Sep 13, 2017 · 1 comment
Closed

--link-module Windows support? #15377

anmonteiro opened this issue Sep 13, 2017 · 1 comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@anmonteiro
Copy link

  • Version: 8.5.0
  • Platform: Windows
  • Subsystem: build

I recently found myself compiling Node.js and wanting to include an extra module via --link-module /path/to/module.

While this works great when building for Linux or macOS, it seems to lack Windows support.

Am I doing something wrong?
@mscdex mscdex added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Sep 13, 2017
bzoz added a commit to JaneaSystems/node that referenced this issue Sep 14, 2017
@bzoz
build: add support for link-module to vcbuild
f69a62b 
Adds support for link-module option to vcbuild.bat.

Fixes: nodejs#15377
@bzoz bzoz mentioned this issue Sep 14, 2017
Closed
2 tasks
@bzoz
Copy link
Contributor

bzoz commented Sep 14, 2017

Looks like it is missing. I've opened a PR to fix this: #15410

jasnell pushed a commit that referenced this issue Sep 20, 2017
@bzoz @jasnell
build: add support for link-module to vcbuild
5d217ad 
Adds support for link-module option to vcbuild.bat.

PR-URL: #15410
Fixes: #15377
Reviewed-By: Refael Ackermann <refack@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
@bzoz
build: add support for link-module to vcbuild
8ceb08a 
Adds support for link-module option to vcbuild.bat.

PR-URL: nodejs/node#15410
Fixes: nodejs/node#15377
Reviewed-By: Refael Ackermann <refack@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
@bzoz
build: add support for link-module to vcbuild
8db4f20 
Adds support for link-module option to vcbuild.bat.

PR-URL: nodejs/node#15410
Fixes: nodejs/node#15377
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: add support for link-module to vcbuild JaneaSystems/node
3 participants
@mscdex @anmonteiro @bzoz