Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Test failed on Windows 7 #16023

Closed
xanZ08 opened this issue Oct 6, 2017 · 2 comments
Closed

Build Test failed on Windows 7 #16023

xanZ08 opened this issue Oct 6, 2017 · 2 comments
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@xanZ08
Copy link

xanZ08 commented Oct 6, 2017

On running .\vcbuild test below test case fails. Here is the stack trace.

Error: Command failed: "C:\Users\816361\Documents\xan\nodecore\node\Release\node.exe" -e 'require("child_process").fork("C:\Users\816361\Documents\xan\nodecore\node\test\fixtures\empty.js")'
[eval]:1
'require(child_process).fork(C:\Users\816361\Documents\xan\nodecore\node\test\fixtures\empty.js)'


SyntaxError: Invalid hexadecimal escape sequence
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:600:30)
    at evalScript (bootstrap_node.js:462:27)
    at startup (bootstrap_node.js:163:9)
    at bootstrap_node.js:605:3

    at ChildProcess.exithandler (child_process.js:269:12)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:944:16)
    at Socket.stream.socket.on (internal/child_process.js:364:11)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at Pipe._handle.close [as _onclose] (net.js:551:12)

Version: output of node -v - > v6.9.1
Windows 7 64 bit

@mscdex mscdex added test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Oct 6, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 6, 2017

Reduced case:

const trickyString = 'c:\\xfolder\\file.js';

require("child_process").execSync(`"${process.execPath}" -e "'${trickyString}'"`);
[eval]:1
'c:\xfolder\file.js'
   ^^^^

SyntaxError: Invalid hexadecimal escape sequence
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:624:30)
    at evalScript (bootstrap_node.js:461:27)
    at startup (bootstrap_node.js:163:9)
    at bootstrap_node.js:607:3
child_process.js:635
    throw err;
    ^

Error: Command failed: "C:\Program Files\nodejs\node.exe" -e "'c:\xfolder\file.js'"
[eval]:1
'c:\xfolder\file.js'
   ^^^^

SyntaxError: Invalid hexadecimal escape sequence
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:624:30)
    at evalScript (bootstrap_node.js:461:27)
    at startup (bootstrap_node.js:163:9)
    at bootstrap_node.js:607:3

    at checkExecSyncError (child_process.js:592:13)
    at Object.execSync (child_process.js:632:13)
    at Object.<anonymous> (...\test.js:5:26)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:187:16)

bzoz added a commit to JaneaSystems/node that referenced this issue Oct 10, 2017
Escape backslashes in script filename on Windows in a CLI test.

Fixes: nodejs#16057
Fixes: nodejs#16023
jasnell pushed a commit that referenced this issue Oct 13, 2017
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Oct 18, 2017
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bzoz
Copy link
Contributor

bzoz commented Nov 9, 2017

This was fixed in 07ec10d

@bzoz bzoz closed this as completed Nov 9, 2017
MylesBorins pushed a commit that referenced this issue Nov 16, 2017
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 21, 2017
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 28, 2017
Escape backslashes in script filename on Windows in a CLI test.

PR-URL: #16124
Fixes: #16057 and #16023
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

4 participants