Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning/Notice when processing V8 profiler output from same binary #16736

Closed
mscdex opened this issue Nov 4, 2017 · 1 comment
Closed

Warning/Notice when processing V8 profiler output from same binary #16736

mscdex opened this issue Nov 4, 2017 · 1 comment
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@mscdex
Copy link
Contributor

mscdex commented Nov 4, 2017

  • Version: master
  • Platform: Linux
  • Subsystem: v8

Using node with --prof and then --prof-process with the same binary results in this message being printed before the formatted output: 'Testing v8 version different from logging version'.
@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Nov 4, 2017
@bnoordhuis bnoordhuis mentioned this issue Nov 5, 2017
Merged
@bnoordhuis
Copy link
Member

#16769

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Nov 7, 2017
@bnoordhuis
lib: fix version check in tick processor
421316d 
Introduced in 70832bc ("build: add V8 embedder version string".)

Fixes: nodejs#16736
PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Nov 7, 2017
@bnoordhuis
test: tick processor version check regression test
698bb96 
Verify that v8-version log lines are parsed and matched correctly.

Fixes: nodejs#16736
PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this issue Nov 7, 2017
@bnoordhuis @cjihrig
lib: fix version check in tick processor
c14030e 
Introduced in 70832bc ("build: add V8 embedder version string".)

Fixes: nodejs#16736
PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this issue Nov 7, 2017
@bnoordhuis @cjihrig
test: tick processor version check regression test
2294ba4 
Verify that v8-version log lines are parsed and matched correctly.

Fixes: nodejs#16736
PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @bnoordhuis