-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to update source exclusions for ICU 61 #16937
Comments
should have read the guide in #7843 ! |
OK, looking at the exclusions: I only put them in for 55 and 57 (copy and paste). So they are missing for 56(#3281), 58 (#9234/#10206), 59 (#12486) AND 60 (#16876). So this is not a new issue. Also fixing this now would break the floating patch #16931 without some care. (it could be re-applied) Eminently back-port-able. Instead of copy and paste, a range should be used for exclusions. |
^ floating patch mentioned above is rolled into the #17687 so shouldn't be a problem. |
@apapirovski no, this a minor improvement is to add some more exclusions. It was unblocked by the above. Should now be 61 due to #19621 |
@srl295 ... still needed? |
#16876 landed ICU 60.1 but didn't update the source exclusions in
icu_generic.gyp
. As a result:This would cause NO change in actual behavior, because the files aren't actually executed (or their removal would have caused the build to fail).
The text was updated successfully, but these errors were encountered: