-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: ICU 59.1 bump #12486
deps: ICU 59.1 bump #12486
Conversation
OK! v8 now fixed, this should be good. #11753 (comment) |
^ rebased, PTAL all. Will start CI. |
fwiw code starting with |
^ CI green ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Works on my machine.
Thanks! FYI @ilovezfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber Stamp LGTM.
@srl295 could you paste the link to the CI run into one of the comments for posterity. |
* No feature changes. * Bug fixes. * Details: http://site.icu-project.org/download/59 Fixes: nodejs#12077 PR-URL: nodejs#12486 Refs: nodejs#7844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
* No feature changes. * Bug fixes. * Details: http://site.icu-project.org/download/59 Fixes: nodejs#12077 PR-URL: nodejs#12486 Refs: nodejs#7844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
I'm assuming this shouldn't land on v6.x as it depends on V8 5.9. LMK if wrong. |
@gibfahn yes, it would need v8 backported also. |
@srl295 yep, I've confirmed it went into 8.0.0 so we're good there. |
* No feature changes. * Bug fixes. * Details: http://site.icu-project.org/download/59 Fixes: nodejs#12077 PR-URL: nodejs#12486 Refs: nodejs#7844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Fixes: #12077
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
deps