Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set windowsHide flag when call child_process.fork in cluster.fork #17370

Closed
toddwong opened this issue Nov 28, 2017 · 0 comments
Closed

Set windowsHide flag when call child_process.fork in cluster.fork #17370

toddwong opened this issue Nov 28, 2017 · 0 comments
Labels
child_process Issues and PRs related to the child_process subsystem. feature request Issues that request new features to be added to Node.js. windows Issues and PRs related to the Windows platform.

Comments

@toddwong
Copy link
Contributor

toddwong commented Nov 28, 2017 •
edited
Loading

I'm not very sure about this, actually i'm a newbie to node's cluster, but it doesn't make a lot of sense to me to show many console windows when build a cluster.

For a real world scenario, I'm using pm2 with the --instances argument. It opens too many black console windows, which really annoying.
@toddwong toddwong changed the title Set windowsHide flag where call child_process.fork in cluster.fork Set windowsHide flag when call child_process.fork in cluster.fork Nov 28, 2017
@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. feature request Issues that request new features to be added to Node.js. windows Issues and PRs related to the Windows platform. labels Nov 28, 2017
@toddwong toddwong mentioned this issue Nov 28, 2017
Open
@toddwong toddwong mentioned this issue Dec 1, 2017
Closed
4 tasks
toddwong added a commit to toddwong/node that referenced this issue Dec 2, 2017
@toddwong
cluster: support windowsHide option for workers
45134fb 
Fixes: nodejs#17370
MylesBorins pushed a commit that referenced this issue Jan 8, 2018
@toddwong @MylesBorins
cluster: support windowsHide option for workers
e8abfeb 
Fixes: #17370

PR-URL: #17412
Fixes: #17370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@toddwong @MylesBorins
cluster: support windowsHide option for workers
1aa99eb 
Fixes: #17370

PR-URL: #17412
Fixes: #17370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@toddwong @MylesBorins
cluster: support windowsHide option for workers
d066db7 
Fixes: #17370

PR-URL: #17412
Fixes: #17370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 2, 2018
@toddwong @MylesBorins
cluster: support windowsHide option for workers
62b4a1b 
Fixes: #17370

PR-URL: #17412
Fixes: #17370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this issue Aug 16, 2018
@toddwong @rvagg
cluster: support windowsHide option for workers
76805f0 
Fixes: #17370

PR-URL: #17412
Fixes: #17370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. feature request Issues that request new features to be added to Node.js. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mscdex @toddwong