Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting error in test-sync-io-option #1742

Closed
santigimeno opened this issue May 20, 2015 · 5 comments
Closed

Linting error in test-sync-io-option #1742

santigimeno opened this issue May 20, 2015 · 5 comments

Comments

@santigimeno
Copy link
Member 

gmake jslint
gmake[1]: Entering directory '/usr/home/sgimeno/node/io.js'
./iojs tools/eslint/bin/eslint.js src lib test --reset --quiet

test/parallel/test-sync-io-option.js
  39:6  error  Expected indentation of 6 characters  indent

✖ 1 problem (1 error, 0 warnings)

Not sure it should complain though. I think https://github.com/nodejs/io.js/blob/master/test/parallel/test-sync-io-option.js#L39 is correctly indented
targos added a commit to targos/node that referenced this issue May 20, 2015
@targos
test: fix jslint error
38413f9 
Fixes: nodejs#1742
@targos targos mentioned this issue May 20, 2015
Closed
@targos
Copy link
Member

targos commented May 20, 2015

I recently ran into this in another project.
It can be fixed by adding curly brackets though I do not know if the warning is intended or if it is a bug from eslint

@targos
Copy link
Member

targos commented May 20, 2015

@nzakas ?

@silverwind
Copy link
Contributor

Yeah, that error message is pretty misleading.

silverwind pushed a commit that referenced this issue May 20, 2015
@targos @silverwind
test: fix jslint error
5773438 
PR-URL: #1743
Fixes: #1742
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

Landed in 5773438, maybe you can open an issue in eslint if there isn't one already.

@targos
Copy link
Member

targos commented May 20, 2015

I found this : eslint/eslint#2343

andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this issue Jun 3, 2015
@targos @andrewdeandrade
test: fix jslint error
0c4c2b5 
PR-URL: nodejs/node#1743
Fixes: nodejs/node#1742
Reviewed-By: Roman Reiss <me@silverwind.io>
@targos targos mentioned this issue Jun 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix jslint error targos/node
3 participants
@silverwind @santigimeno @targos