-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize an HTTP Server as a Transform #186
Closed
formula1 opened this issue
Dec 20, 2014
· 1 comment
· May be fixed by olegnn/node#29, erdun/node#34 or saeedahassan/node#28
Closed
Standardize an HTTP Server as a Transform #186
formula1 opened this issue
Dec 20, 2014
· 1 comment
· May be fixed by olegnn/node#29, erdun/node#34 or saeedahassan/node#28
Comments
This may be more appropiate for Node Forward than here |
This was referenced May 26, 2021
syg
pushed a commit
to syg/node
that referenced
this issue
Jun 20, 2024
…s#186) (nodejs#189) * Fix test-http-server-keepalive-req-gc * Format --------- Co-authored-by: Etienne Pierre-Doray <etipdoray@gmail.com> Co-authored-by: Etienne Pierre-doray <etiennep@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a low priority enhancement. But I do believe this is important in general to set a standard. That being said, the http server spans about... 8 different files with a collective 2661 lines (120+145+498+624+198+228+572+276) (some of which is repeated such as http and https). So I completely understand that this idea is going to be taken lightly if not ignored completely. However, seeing from the last TC meeting, you guys really are paying attention. And it warms my icy cold heart.
The problem
Nodejs already set the standard for using stream.Transform in servers, don't.
It can only be found in Crypto and zlib within the source
However, the nodejs implementers guide suggests using the transform for protocols. I'm not here to complain about hipocracy as much as I'm here to complain about how because node didn't lead by example others didn't follow and understand why it wasn't implemented that way.
Consequences
Other solutions
Psuedocode
Some related Lines
The text was updated successfully, but these errors were encountered: