Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test_callback_scope/test-resolve-async #18702

Closed
BridgeAR opened this issue Feb 10, 2018 · 0 comments · Fixed by #18719
Closed

Flaky test_callback_scope/test-resolve-async #18702

BridgeAR opened this issue Feb 10, 2018 · 0 comments · Fixed by #18719
Labels
addons Issues and PRs related to native addons. flaky-test Issues and PRs related to the tests with unstable failures on the CI. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Comments

@BridgeAR
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-linux/16293/nodes=alpine35-container-x64/console

not ok 1963 addons-napi/test_callback_scope/test-resolve-async
  ---
  duration_ms: 0.534
  severity: fail
  stack: |-
    (node:23280) Warning: N-API is an experimental feature and could change at any time.
    assert.js:243
        throw err;
        ^
    
    AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert(called)
    
        at Timeout.common.mustCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/test/addons-napi/test_callback_scope/test-resolve-async.js:12:36)
        at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/test/common/index.js:475:15)
        at ontimeout (timers.js:441:11)
        at tryOnTimeout (timers.js:303:5)
        at listOnTimeout (timers.js:266:5)
        at Timer.processTimers (timers.js:226:10)
  ...
@BridgeAR BridgeAR added test Issues and PRs related to the tests. addons Issues and PRs related to native addons. node-api Issues and PRs related to the Node-API. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Feb 10, 2018
@cjihrig cjihrig mentioned this issue Feb 11, 2018
Merged
3 tasks
@benjamingr benjamingr mentioned this issue Feb 14, 2018
Closed
4 tasks
cjihrig added a commit to cjihrig/node that referenced this issue Feb 14, 2018
@cjihrig
test: remove unnecessary timer
755e07c 
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.

PR-URL: nodejs#18719
Fixes: nodejs#18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@cjihrig @MylesBorins
test: remove unnecessary timer
5914241 
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.

PR-URL: #18719
Fixes: #18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 21, 2018
@cjihrig @MylesBorins
test: remove unnecessary timer
18c4933 
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.

PR-URL: #18719
Fixes: #18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 12, 2018
@cjihrig
test: remove unnecessary timer
a1df466 
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.

PR-URL: nodejs#18719
Fixes: nodejs#18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 16, 2018
@cjihrig
test: remove unnecessary timer
a12f442 
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.

PR-URL: nodejs#18719
Fixes: nodejs#18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 16, 2018
@cjihrig @MylesBorins
test: remove unnecessary timer
7c58045 
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.

Backport-PR-URL: #19447
PR-URL: #18719
Fixes: #18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue May 1, 2018
@cjihrig @MylesBorins
test: remove unnecessary timer
6129ff4 
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.

Backport-PR-URL: #19265
PR-URL: #18719
Fixes: #18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@cjihrig @MayaLekova
test: remove unnecessary timer
398f530 
The timer in NAPI's test_callback_scope/test-resolve-async.js
can be removed. If the test fails, it will timeout on its own.
The extra timer increases the chances of the test being
flaky.

PR-URL: nodejs#18719
Fixes: nodejs#18702
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. flaky-test Issues and PRs related to the tests with unstable failures on the CI. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: remove unnecessary timer cjihrig/node
1 participant
@BridgeAR