Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core dump during postinstall script with node v10.0.0 #20281

Closed
adrai opened this issue Apr 25, 2018 · 7 comments
Closed

core dump during postinstall script with node v10.0.0 #20281

adrai opened this issue Apr 25, 2018 · 7 comments
Labels
vm Issues and PRs related to the vm subsystem. wrong repo Issues that should be opened in another repository.

Comments

@adrai
Copy link

adrai commented Apr 25, 2018

Everything worked fine with node v8.x
I don't know exactly where, but somewhere in my postinstall script on a special jenkins vm, something gets wrong...
I have no tooling to analyze the core dump, can someone have a look at it?

node[3772]: ../src/node_contextify.cc:631:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' failed.
 1: node::Abort() [node]
 2: 0x87b6c5 [node]
 3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [node]
 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [node]
 5: 0xad5b9f [node]
 6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 7: 0x86daa40427d
Aborted (core dumped)
@bnoordhuis bnoordhuis added the vm Issues and PRs related to the vm subsystem. label Apr 25, 2018
@bnoordhuis
Copy link
Member

I can't check the core dump right now but my guess would be that you have code somewhere, possibly in a dependency, that uses process.binding('contextify') directly.

@adrai
Copy link
Author

adrai commented Apr 25, 2018 •
edited
Loading

Yes, can confirm via https://github.com/EvanOxfeld/node-unzip dependency
-> https://github.com/npm/fstream
-> https://github.com/isaacs/node-graceful-fs
-> https://github.com/addaleax/natives/blob/master/index.js#L12

@bnoordhuis
Copy link
Member

bnoordhuis commented Apr 25, 2018 •
edited
Loading

Right, I see there's already at least one open issue about moving away from natives. I'll close this out because it's not our bug to fix; you might want to chime in on the other bug report.

@bnoordhuis bnoordhuis added the wrong repo Issues that should be opened in another repository. label Apr 25, 2018
@adrai
Copy link
Author

adrai commented Apr 25, 2018

ok, thx

@bnoordhuis bnoordhuis mentioned this issue Apr 25, 2018
Closed
@jperelli
Copy link

I updated "grunt-bower-task": "0.4.0", to "grunt-bower-task": "0.5.0", and that fixed it for me, based on the deprecation notice here https://www.npmjs.com/package/natives

@apapirovski apapirovski mentioned this issue Apr 26, 2018
Closed
This was referenced Apr 27, 2018
Closed
Closed
@jcoby jcoby mentioned this issue Apr 27, 2018
Closed
@vladimyr vladimyr mentioned this issue Apr 29, 2018
Merged
@michaelglass michaelglass mentioned this issue May 2, 2018
Closed
@mukulmishra18 mukulmishra18 mentioned this issue May 3, 2018
Merged
@sum01 sum01 mentioned this issue May 17, 2018
Closed
2 tasks
@BB-000
Copy link

BB-000 commented May 31, 2018

I fixed this by running 'yarn'

mwiencek added a commit to metabrainz/musicbrainz-server that referenced this issue Jun 5, 2018
@mwiencek
Update gulp dependencies in yarn.lock
ca0d050 
This works around
nodejs/node#20281
@Knogobert
Copy link

After running yarn as @BB-000 suggested I got another problem. It was solved by rebuilding node-sass via npm rebuild node-sass. Hope it helps someone!

calebeby added a commit to cloudfour/core-gulp-tasks that referenced this issue Jun 22, 2018
@calebeby
Fix test issue
b4bc92c 
Solved with rm package-lock.json; npm i
That's sad :(

nodejs/node#20281
Was running into this issue, but it was solved after resetting lockfile
@calebeby calebeby mentioned this issue Jun 22, 2018
Merged
@ccprog ccprog mentioned this issue Sep 13, 2018
Closed
hangy added a commit to openfoodfacts/openfoodfacts-server that referenced this issue Sep 21, 2018
@hangy
Reset yarn.lock to fix core dump related to gulp.
5f5ae62 
see nodejs/node#20281
teolemon added a commit to openfoodfacts/openfoodfacts-server that referenced this issue Oct 27, 2018
@teolemon
sq (#1448)
9753ef5 
* HR Content (#1346)

HR Content

* GA content (#1358)

GA content

* Delete index.html

* Ro content (#1347)

Ro content

* open beauty facts specific strings (#1335)

* Replace { "key" => $key} by { key => $key }.

* Fix HTML syntax error in translations.

* Suomi (fi) (#1345)

Suomi (fi)

* Delete open-food-hunt-2015.html

* Delete index.html

* lv content (#1352)

lv content

* Expand Open Pet Food Facts specific strings

* Portuguese translations refresh

* Delete index.html

* Delete index.html

* Delete index.html

* Japanese content (#1370)

Japanese content

* Turkish content (#1371)

Turkish content

* Hebrew updates (#1369)

Hebrew updates

* Indonesian (#1365)

* chinese-update (#1366)

chinese-update

* Delete index.html

* Russian translations updates (#1368)

* Russian translations updates

Russian translations updates

* Delete index.html

* off specific strings (#1336)

* Rename common-web.pot to obsolete.pot

* Update common.pot

* Update common.pot

* nova config

* cleanup

* new welcome email, footer links

* partners page

* Address review comments.

* Update Dockerfile

Update Alpine package cache once.

see gliderlabs/docker-alpine#207

* Update Dockerfiles

- Ignore more directories/files.
- Update Alpine package index explicitly.
- Use multi-stage build for a little bit leaner backend runtime builds.
- Add multi-stage build frontend image.-

* Ignore some *huge* images/presentations in the misc directory.

* Remove yarn.lock from .dockerignore to ensure that the Docker image is build with the correct snapshot.

* Further optimize frontend Dockerfile by only copying the html directory that's being served by nginx.

* Reset yarn.lock to fix core dump related to gulp.

see nodejs/node#20281

* Update openproductsfacts.pot

* display risk of additivs overexposure, bug #1374

* Update en.po

Fix merge error. Closes #1114

Co-authored-by: Mohit Sharma <ms10398@users.noreply.github.com>
Signed-off-by: hangy <hangy@hangy.de>

* display risk of over-exposure for additives, bug #1374

* display risk of over-exposure for additives, bug #1374

* small updates and https support for howmuchsugar.in combiendesucres.fr

* update paths

* Open Beauty Facts taxonomies

* small fix

* merge static pages for small languages

* arabic static pages

* add French translations in addition to current translations

* add obf static pages

* vietnamese (#1387)

* common-many (#1389)

* common files for many languages (#1388)

* states taxonomy translations

* Update ko.po

* Update bn.po

* Update eu.po

* Add files via upload (#1390)

* OPF fixes part 2

* Italy static refresh (#1391)

* arabic static updates

* Danish

* Fix h2 tag

* Hebrew translations

* fixing CoC for ja

* Add files via upload

* fixes for OBF specific strings

* fixes for OFF specific strings

* fixes for OPFF

* German common translations (#1386)

* German common translations

German common translations

* Fix some incorrect translations and match _s/_p translations to use the same word.

* Add files via upload

* Add a simple Kubernetes config.s

Squashed commit of the following:

commit 7608cc1
Author: hangy <hangy@hangy.de>
Date:   Wed Sep 26 14:49:55 2018 +0200

    Log the Log4Perl output to a sidecar container to make it available to Kubernetes.ton

commit 3766824
Author: hangy <hangy@hangy.de>
Date:   Wed Sep 26 14:01:23 2018 +0200

    Add init container.

commit b83f6e5
Author: hangy <hangy@hangy.de>
Date:   Wed Sep 26 13:36:22 2018 +0200

    Remove `scripts` from dockerignore.

    We actually need scripts like build_lang.pl to init the containers..r

commit e9172e4
Author: hangy <hangy@hangy.de>
Date:   Wed Sep 26 12:31:34 2018 +0200

    Update backend-dev to use the same copy mechanism as backend.

commit 8e9aa06
Author: hangy <hangy@hangy.de>
Date:   Sat Sep 22 12:22:27 2018 +0200

    Add Kubernetes configuration for the backend

commit a771793
Author: hangy <hangy@hangy.de>
Date:   Fri Sep 21 16:35:41 2018 +0200

    Add Kubernetes configuration for the frontend.Aadd Kubernetes configuration for the frontend.

* update ingredients taxonomy, fix ingredients test

* fix for allergens

* Add Kubernetes config as a helm chart.

Squashed commit of the following:

commit b7f9f824d6d71331e25e9e188a3909a22a0c3e05
Author: hangy <hangy@hangy.de>
Date:   Thu Sep 27 00:03:03 2018 +0200

    Set higher limit for backend liveness probes.

commit 0c665519c0f830a32737b2737946f4c224d47d89
Author: hangy <hangy@hangy.de>
Date:   Wed Sep 26 23:46:31 2018 +0200

    Fix named port in readyness/liveness check.

commit 27bfc4ca8f8f0cfd69c6b3594881e0602cd0dbd5
Author: hangy <hangy@hangy.de>
Date:   Wed Sep 26 23:28:29 2018 +0200

    Add stable/mongodb as a reference.

commit 963de1279edfe5bfdefcad806da728ad8df33c67
Author: hangy <hangy@hangy.de>
Date:   Wed Sep 26 23:08:04 2018 +0200

    Move kubernetes files to a simple Helm chart.

    This still needs to include MongoDB.

* Add files via upload

* small fixes for additives and ingredients (stopwords)

* scripts to generate taxonomies, new additives_classes taxonomy with descriptions

* added additives classes to additives taxonomy

* update additives classes taxonomies

* update obf ingredients

* Squashed commit of the following:

commit 002aa7cf965cd2929fb8e1a49b7f16c60975039d
Author: hangy <hangy@hangy.de>
Date:   Sat Sep 29 10:42:15 2018 +0200

    Avoid accidentally adding the charts directory to git.

commit 7f474c751a5b2a9798addff4b76d6d9428b17497
Author: hangy <hangy@hangy.de>
Date:   Sat Sep 29 02:37:51 2018 +0200

    Use full release name for PVCs.

commit bbcccfbf7bbb278f5c1e8dedc24b771365c8b7dc
Author: hangy <hangy@hangy.de>
Date:   Sat Sep 29 02:31:34 2018 +0200

    Frontend does not need to write to the product images mount.

* Use ESLint instead of JSHint.

In comparison with JSHint, ESLint seems to be more configurable, and allows plugins to be used.

* Update backend dockerfile

* new structured data for overexposure risk + fix for e-numbers with a letter

* Apply suggestions from 40524a5 to other Dockerfiles.

* added Kosovo

* Use full K8S/helm generated backend service name.

* add wikipedia abstracts in additives taxonomy

* new structured data for overexposure risk + fix for e-numbers with a letter

* new structured data for overexposure risk + fix for e-numbers with a letter

* Ignore `.vstags`

* fixing unescaped url

* generate 2 json files for taxonomies, with or without wikipedia abstracts

* put back stopwords in additives taxonomy

* add .editorconfig

* allow to undeleted products

* add automatic generation of table of contents for texts

* guide for producers

* make sure English is listed first

* updates to labels and ingredients taxonomies

* Update common.pot

* Update az.po

* Update bg.po

* Update bn.po

* Update ca.po

* Update cs.po

* Update ar.po

* update tags

* Update fr.po

* update paths

* Use a static file for nginx' live/ready check.

* Fix MongoDB host for Helm.

* Add files via upload (#1421)

* Fixes #856: Remove s from aperçus (#1420)

* Remove s from aperçus

* Remove s from aperçus

* fix typo

* translation merging

* obf merge

* more translation merges

* Not translate footer links

* Fix travis vi lang test

Not translate footer links. Just translate footer labels.

* Fix travis by following Perl::Critic policy check

Perl::Critic encoding policy requires ":encoding(UTF-8)"
cf. https://metacpan.org/pod/release/ELLIOTJS/Perl-Critic-1.116/lib/Perl/Critic/Policy/InputOutput/RequireEncodingWithUTF8Layer.pm

* Fix travis by following Perl::Critic policy check

Perl::Critic encoding policy requires ":encoding(UTF-8)"
cf. https://metacpan.org/pod/release/ELLIOTJS/Perl-Critic-1.116/lib/Perl/Critic/Policy/InputOutput/RequireEncodingWithUTF8Layer.pm

* Fix contribute and discover links

* update according to goot pratices

* Update vi.po

* Update vi.po

* Update de.po

* add missing files

* refresh states

* commit changes to faq

* fix opf

* opff fixes

* fix obf

* fix off

* merge static files

* add common for s languages will break links

* more common files

* add t files

* fix perl warnings

* Add files via upload

* add producer page for translations

* Delete .DS_Store

* Add files via upload

* fix stats headers in nutrition tables, add nutriscore

* update the categories taxonomy

* add producer pages

* aucun changement

* merge more langs

* Update sl.po

* Add files via upload

* merge

* Remove manual CSRF token checks.

* Use SameSite=Lax for CSRF defense.

* Use up-to-date DateTime module instead of DateTime::Format::CLDR for datetime formatting.

* Remove apparently unused DateTime::Format::Mail module.

* Generate 'months' and 'weekdays' translations using the DateTime::Locale module.

* Update unit tests

- Months tests needs to match the content-wise equivalent JSON:PP output,
- Weekdays should probably be tested.A

* Fix display_date_tag.

* Make memcached server address configurable.

* hebrew updates

* New translations common.pot (Hebrew)

* New translations open-food-hunt-2015.html (Hebrew)

* New translations producers.html (Hebrew)

* new admin

* fix permissions back to 644

* Divide percentage by 100.0 to avoid display issues.

* Include bower_components in the Docker context, so that it can be added to the HTML directory.

* Until #666 is fixed, we need to pin MongoDB to <2.0.

Deprecated methods like MongoDB::Cursor::count were removed in 2.0 and
thus caused the following error if a more recent MongoDB was installed.

Can't locate object method "count" via package "MongoDB::Cursor" at
/opt/product-opener/lib/ProductOpener/Display.pm line 3159.

* Fix locale existence check.

* Copy @bower_components from the builder stage.

* Remove livenessProbe and readinessProbe for the backend.

* Update crowdin.yml

* new tests for additives and ingredients

* clean ingredients list and remove nutrition facts from them, bug #1433

* clean ingredients list and remove nutrition facts from them, bug #1433

* Update .editorconfig

* more ingredients list cleaning, bug #1433

* Update Ingredients.pm

* Update Ingredients.pm

* Update Ingredients.pm

* added 2 labels

* overflow tag list #246

* new after ingredients strings

* remove useless slash in HTML5

* remove extra % signs, call decimal formatter for all places in the nutrition table

* fixes to the English producer page

* Update producers.html

* Delete obsolete.pot

* Update Crowdin configuration file

* allow multiple spaces

* Italian logo

* Italian logo

* Vi and it

* support for Italy

* Add files via upload

* NOVA

* rename Vietnamese text

* added a donation top banner

* rename Vietnamese text

* fix

* fixes

* New translations nova-groups-for-food-processing.html (Spanish) (#1447)
@teolemon teolemon mentioned this issue Oct 27, 2018
Closed
5 tasks
@azz azz mentioned this issue Feb 6, 2019
Closed
@zacharyp zacharyp mentioned this issue Apr 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vm Issues and PRs related to the vm subsystem. wrong repo Issues that should be opened in another repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bnoordhuis @Knogobert @adrai @jperelli @BB-000