Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: add new collaborators #VI #2102

Closed
Fishrock123 opened this issue Jul 3, 2015 · 25 comments
Closed

governance: add new collaborators #VI #2102

Fishrock123 opened this issue Jul 3, 2015 · 25 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@Fishrock123
Copy link
Contributor

I think I can run this one, since @chrisdickinson is pretty busy. :)

Thread is otherwise open for @nodejs/tc to nominate folks for onboarding as per our governance. @nodejs/collaborators, feel free to make suggestions.

Previous onboarding threads: [5], [4], [3], [2], [1].

@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Jul 3, 2015
@Fishrock123
Copy link
Contributor Author

Nominating:

@thefourtheye (commits)
@targos (commits)

Please let us know if you'd be willing, and then available for a ~1h onboarding call. More details on times later.

I'll be at CascadiaJS most of next week, but the week after might be good.

@chrisdickinson
Copy link
Contributor

cc @nodejs/tsc (that pesky "s"!)

@thefourtheye
Copy link
Contributor

I would love to serve as a collaborator :-)

@targos
Copy link
Member

targos commented Jul 4, 2015

I'd be very happy to become a collaborator !

@benjamingr
Copy link
Member

+1 for @thefourtheye !!

@Fishrock123
Copy link
Contributor Author

@thefourtheye & @targos Doodle here for times. I think I did it a little weird, never set one up before. I can do most times on these days except for Wednesday around the TSC meeting.

So if you could, please put in your preferred times. The poll was created in PST but should auto-detect your timezone. If none of that works, let me know and I'll figure something else out.

http://doodle.com/sasg9en3muammtut

@Fishrock123
Copy link
Contributor Author

@chrisdickinson could you send me your gist? I'd like to update it a bit if you didn't already.

@targos
Copy link
Member

targos commented Jul 16, 2015

@Fishrock123 in case you didn't subscribe for updates, the Doodle is complete.

@Fishrock123
Copy link
Contributor Author

@thefourtheye @targos how about tomorrow (Friday the 17th) at 1pm PST?

It should only take 45min if you're busy, but I can spend some more time to go into more detail if desired. (Also this is my first time leading an onboarding so we'll see how it goes haha)

@rvagg
Copy link
Member

rvagg commented Jul 17, 2015

I'd like to suggest @joaocgreis for this list if he wants to, he's been very helpful on windows issues, particularly on the build & test side. Might be late for this one tho I suppose.

@Fishrock123
Copy link
Contributor Author

@joaocgreis Are you able to make it tomorrow (Friday PST) at 1pm PST, or around that time? If not we'll just do you some other time soon. :)

@thefourtheye
Copy link
Contributor

@Fishrock123 I can attend at 1 PM PST.

@Fishrock123
Copy link
Contributor Author

@targos @thefourtheye @joaocgreis Actually, 2pm PST works better for me, but if that doesn't work it's ok and we'll do it at 1. (Sorry!)

@targos
Copy link
Member

targos commented Jul 17, 2015

@Fishrock123 I'm fine with both

@thefourtheye
Copy link
Contributor

Even I am okay to attend at 2PM PST. Anyway I stay up very late these days :D

@Trott
Copy link
Member

Trott commented Jul 17, 2015

@Fishrock123, @thefourtheye: Note that this time of year, the west coast of the U.S. and the west coast of Canada are on PDT, not PST. If you're using the timezone abbreviation to convert to local time, you may be off by one hour if you use PST. (On the other hand, if you are relying on Doodle or some other website to do the conversion for you, then it doesn't matter and you can ignore me.)

@joaocgreis
Copy link
Member

I'd be very happy to become a collaborator! @rvagg thanks for suggesting me!

@Fishrock123 2PM PST is fine today, I'll join the meeting.

@joaocgreis
Copy link
Member

@Fishrock123 Where do we meet? Can you confirm that the meeting is in 1h05m time (2PM PST) and not in 5m time (2PM PDT)? Thanks!

@Fishrock123
Copy link
Contributor Author

@joaocgreis Sorry, looks like I got the timezones mixed up.. I guess it's supposed to be EDT? If you can't make now I'll do you in an hour.

@targos @thefourtheye I'm running a couple minutes late, but I'll send the hangout link momentarily.

@joaocgreis
Copy link
Member

@Fishrock123 I can, it's even better for me. Send me the link too!

@targos
Copy link
Member

targos commented Jul 17, 2015

@Fishrock123 I am online and ready

@Fishrock123
Copy link
Contributor Author

thefourtheye added a commit to thefourtheye/io.js that referenced this issue Jul 17, 2015
@Fishrock123
Copy link
Contributor Author

This one's done, thanks all!

Here is the updated gist I used as a guide: https://gist.github.com/Fishrock123/8d458a00b3164f472691

@targos @joaocgreis let me know he is going to do his add-as-collaborator commit on monday-ish. :)

thefourtheye added a commit that referenced this issue Jul 17, 2015
Refer: #2102

PR-URL: #2199
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@thefourtheye
Copy link
Contributor

@Fishrock123 Was it him? I thought it was @joaocgreis.

@Fishrock123
Copy link
Contributor Author

@thefourtheye whoops, looks like it.

targos added a commit to targos/node that referenced this issue Jul 17, 2015
Ref: nodejs#2102

PR-URL: nodejs#2200
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
joaocgreis added a commit that referenced this issue Jul 21, 2015
Refer: #2102

PR-URL: #2208

Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

8 participants